Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be a good way to mix filters #95

Closed
sontek opened this issue Feb 2, 2012 · 4 comments
Closed

Should be a good way to mix filters #95

sontek opened this issue Feb 2, 2012 · 4 comments

Comments

@sontek
Copy link
Contributor

sontek commented Feb 2, 2012

For instance, if I don't want to define bundles in code and just define everything in my templates, It would be nice to include javascript and coffeescript in the same node like:

{% assets filters="coffeescript, jsmin" output="packed1.js", "themes/grape/js/libs/modernizr-2.0.6.min.js", "portal/coffee/main.coffee" %}
<script type="text/javascript" src="{{ ASSET_URL }}"></script>
{% endassets %}

so that they I only have 1 single javascript file instead of multiple.

@sontek
Copy link
Contributor Author

sontek commented Feb 2, 2012

#94 (comment) Would also solve this issue

@miracle2k
Copy link
Owner

This will be fixed via #12. Although not explicitly described in this ticket, the JSBundle/CSSBundle classes will look at file extensions, and automatically apply the correct filters for things like .sass or .coffee files.

@sontek
Copy link
Contributor Author

sontek commented Feb 2, 2012

I don't think that will be enough. Because there will be other needs as well... i.e for coffee, if its in debug mode I would still like the coffeescript filter to execute but not the jsmin filter.

@miracle2k
Copy link
Owner

No, that is how I intend to make it work. Filters like coffeescript would always run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants