Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should webassets auto-generate files (was: pull_external hides the real error) #172

Open
sontek opened this issue Aug 8, 2012 · 3 comments
Labels

Comments

@sontek
Copy link
Contributor

sontek commented Aug 8, 2012

If you include an asset that doesn't exist in a bundle, now that there is the pull_external function you get an IOError rather than an exception letting you know an asset you have included doesn't exist.

@sontek
Copy link
Contributor Author

sontek commented Aug 8, 2012

the pull_external also doesn't seem ideal, some of us would not want webassets touching the disk unless we told it to.

@miracle2k
Copy link
Owner

I don't know if this is true. pull_external runs when generating URLs in debug mode. Whether included files are valid is already checked before that, in resolve_contents.

When I added pull_external, I actually did have some second thoughts, for exactly the reason you say. Still, I think there is possibly a valuable feature there...

@miracle2k
Copy link
Owner

#168 touches on the same thing (should webassets auto-generated files and/or filenames not explicitly given in any output= instruction), so I'm leaving this question open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants