Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom PKG_CONFIG_PATH #196

Closed
TibboddiT opened this issue Jul 29, 2024 · 2 comments · Fixed by #198
Closed

Allow custom PKG_CONFIG_PATH #196

TibboddiT opened this issue Jul 29, 2024 · 2 comments · Fixed by #198
Labels
feature New feature or request good first issue Good for newcomers

Comments

@TibboddiT
Copy link
Contributor

TibboddiT commented Jul 29, 2024

To build miracle, I first build mir locally because I'm not an Ubuntu user and mir libs packaged with my system are too old (and I generally prefer build everything myself).

I therefore need to customize PKG_CONFIG_PATH so that the local mir libs can be found.

In the CmakeLists.txt provided there is this line:

set(ENV{PKG_CONFIG_PATH} "/usr/local/lib/pkgconfig/")

Currently I manually replace this line to have a fully working build phase:

-set(ENV{PKG_CONFIG_PATH} "/usr/local/lib/pkgconfig/")
+set(ENV{PKG_CONFIG_PATH} "$ENV{PKG_CONFIG_PATH}:/usr/local/lib/pkgconfig/")

and I export a custom PKG_CONFIG_PATH before building:

export PKG_CONFIG_PATH="${BASE_DIR}/mir/install/lib/pkgconfig/:$PKG_CONFIG_PATH"
export LD_LIBRARY_PATH="${BASE_DIR}/mir/install/lib:${LD_LIBRARY_PATH}"

(BASE_DIR/mir/install being the install dir of the local mir build)

I'm not a CMake specialist, so I was wondering: is there a way of using a local mir build without modifying the miracle-wm upstream files ?

If not, and if the fix I currently use is acceptable, I can make a PR.

@mattkae mattkae added feature New feature or request good first issue Good for newcomers labels Aug 1, 2024
@mattkae
Copy link
Collaborator

mattkae commented Aug 1, 2024

Hiya @TibboddiT 👋
Thanks for filing the bug. I think that I would prefer a cmake build option instead if you'd like to take a try at it. An example is the SNAP_BUILD option that you can find here.

I would definitely appreciate if you opened the PR for this one 😄

@TibboddiT
Copy link
Contributor Author

See #198 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants