Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines config to package.json #112

Open
awolkers opened this issue Jul 17, 2019 · 5 comments
Open

Add engines config to package.json #112

awolkers opened this issue Jul 17, 2019 · 5 comments
Assignees

Comments

@awolkers
Copy link
Contributor

Add the engines config to the package.json so if someone want to install this the user knows which version of node he needs.
https://docs.npmjs.com/files/package.json#engines

"engines": { "node": ">=8" },

@mdecorte
Copy link
Contributor

I don't know if it's worth the effort of keeping up-to-date. It only gives warnings when building and if you ever run into errors when you're on an old node/npm version that's the first thing you'll check. What's your incentive?

@mdecorte
Copy link
Contributor

Btw: if your app only works on a specific node version that's a problem :D

@colin-aarts
Copy link
Member

@mdecorte why's that?

@mdecorte
Copy link
Contributor

@colin-aarts What's your take it? I just don't see the value. You can always add it yourself if you need it for your project, which should be almost never :P

@mdecorte
Copy link
Contributor

npm docs:

You can also use the “engines” field to specify which versions of npm are capable of properly installing your program. For example:

{ "engines" : { "npm" : "~1.0.20" } }

Unless the user has set the engine-strict config flag, this field is advisory only and will only produce warnings when your package is installed as a dependency.
engineStrict§

This feature was removed in npm 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants