Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate command not working #12

Open
Cmheidelberg opened this issue Feb 21, 2020 · 0 comments
Open

Validate command not working #12

Cmheidelberg opened this issue Feb 21, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Cmheidelberg
Copy link
Collaborator

The validate command could use a more robust documentation. "Validate the JSON obtained after creating one" is a bit vague. What is it validating for? How is it validating? This is ascertainable from the code but a standard user will probably not have access to the source code.

I'm assuming the command is referring to validating the file made from either initialize or push. However, if it it is referring to one of these commands then this should eventually be run automatically after one of those commands is called.

Also despite trying several times I could not get validate to actually run without crashing. This is one of the reasons im pushing for more documentation because I don't know how exactly this command is supposed to be used.

Finally, as I brought up in my notes about push it would be great to have better logging and error handling so the program can crash in a "nice" way if something goes wrong (or user error occurs). I've just copied my earlier examples for helpful types of things for the program to report.

  • "INFO: Converting ModelConfigEample.yaml into JSON"
  • "ERROR: Could not find C:/Users/Admin/ModelCatalogInsertion/test.yaml"
  • "INFO: Generated transformed_json.json"
  • "Success"
@Cmheidelberg Cmheidelberg added the bug Something isn't working label Feb 21, 2020
@dgarijo dgarijo mentioned this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant