Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise the import of scripts into the kickstart file #25

Open
hferentschik opened this issue Oct 18, 2016 · 2 comments
Open

Optimise the import of scripts into the kickstart file #25

hferentschik opened this issue Oct 18, 2016 · 2 comments

Comments

@hferentschik
Copy link
Member

Currently we have something like:

cat > cert-gen.sh.base64 << EOF
${cert_gen}
EOF
base64 -d < cert-gen.sh.base64 > cert-gen.sh

This could be further reduced to

${cert_gen}
chmod +x cert-gen.sh
mv cert-gen.sh /opt

where the boilerplate code is generated as well. In the end it would also expand to something like

cat > cert-gen.sh.base64 << EOF
<base 64 encoded script>
EOF
base64 -d < cert-gen.sh.base64 > cert-gen.sh
@coolbrg
Copy link
Contributor

coolbrg commented Oct 9, 2017

@hferentschik , we have some recent changes related to cert-gen here https://github.com/minishift/minishift-centos-iso/blob/master/centos-7.template#L105-L112.

Do we still need optimization?

@coolbrg coolbrg modified the milestones: v1.3.0, v1.4.0 Oct 9, 2017
@gbraad
Copy link
Member

gbraad commented Oct 9, 2017

This doesn't change the need for the optimization. However, the Fedora livecd creator talks about copying files in the liveroot filesystem. Reading it felt like what we need however I have never been able to make this work for livecd creator for CentOS... ? Maybe it doesnt do what I expect. It mafe no difference using %post or %post -no-chroot

@praveenkumar praveenkumar modified the milestones: v1.4.0, v1.5.0 Dec 11, 2017
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.5.0, v1.6.0 Dec 13, 2017
@coolbrg coolbrg modified the milestones: v1.6.0, v1.7.0 Feb 12, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.7.0, v1.8.0 Feb 15, 2018
@anjannath anjannath modified the milestones: v1.8.0, v1.9.0 Mar 26, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.9.0, v1.10.0 Mar 28, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.10.0, v1.11.0 May 31, 2018
@coolbrg coolbrg modified the milestones: v1.11.0, v1.12.0 Jul 6, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.12.0, v1.13.0 Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants