Skip to content

Commit

Permalink
Log and continue on XFS probe errors during startup (#763)
Browse files Browse the repository at this point in the history
Currently, when any device on the host fails while probing XFS, we error
out which may lead to pod crashloops. We can ignore such device probe
errors and can log and continue.
  • Loading branch information
Praveenrajmani authored May 4, 2023
1 parent 5c14dd1 commit 970ba2f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/device/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func probeDeviceMap() (map[string][]device, error) {
fsuuid, label, totalCapacity, freeCapacity, err := xfs.Probe(utils.AddDevPrefix(dev.Name))
if err != nil {
if !errors.Is(err, xfs.ErrFSNotFound) {
return nil, err
klog.ErrorS(err, "unable to probe XFS filesystem", "Device", dev.Name)
}
continue
}
Expand Down

0 comments on commit 970ba2f

Please sign in to comment.