Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special handling for postgresql-specific migrations #3037

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

jvoisin
Copy link
Collaborator

@jvoisin jvoisin commented Dec 22, 2024

This is a first step towards #1925

@jvoisin
Copy link
Collaborator Author

jvoisin commented Dec 22, 2024

The linter complaining about singleCaseSwitch: should rewrite switch statement to if statement (gocritic) is idiotic, as this is the right construct for type checking.

@fguillot
Copy link
Member

The linter complaining about singleCaseSwitch: should rewrite switch statement to if statement (gocritic) is idiotic, as this is the right construct for type checking.

What about adding a default statement in the switch block, and return an error saying that only the postgres driver is supported at the moment?

@jvoisin jvoisin force-pushed the conditional_migrations branch from f6c352a to a1b42dd Compare December 26, 2024 20:21
@fguillot fguillot merged commit 518bc4d into miniflux:main Dec 26, 2024
15 checks passed
@jvoisin jvoisin deleted the conditional_migrations branch December 26, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants