Skip to content

Commit

Permalink
refactor(oauth2): no need to use io.WriteString when sha256 provide…
Browse files Browse the repository at this point in the history
…s a way to obtain a sum in a single call
  • Loading branch information
jvoisin authored Dec 26, 2024
1 parent bbfe397 commit 89620a7
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions internal/oauth2/authorization.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package oauth2 // import "miniflux.app/v2/internal/oauth2"
import (
"crypto/sha256"
"encoding/base64"
"io"

"golang.org/x/oauth2"

Expand All @@ -33,17 +32,14 @@ func (u *Authorization) CodeVerifier() string {

func GenerateAuthorization(config *oauth2.Config) *Authorization {
codeVerifier := crypto.GenerateRandomStringHex(32)

sha2 := sha256.New()
io.WriteString(sha2, codeVerifier)
codeChallenge := base64.RawURLEncoding.EncodeToString(sha2.Sum(nil))
sum := sha256.Sum256([]byte(codeVerifier))

state := crypto.GenerateRandomStringHex(24)

authUrl := config.AuthCodeURL(
state,
oauth2.SetAuthURLParam("code_challenge_method", "S256"),
oauth2.SetAuthURLParam("code_challenge", codeChallenge),
oauth2.SetAuthURLParam("code_challenge", base64.RawURLEncoding.EncodeToString(sum[:])),
)

return &Authorization{
Expand Down

0 comments on commit 89620a7

Please sign in to comment.