Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong cart rotation on slopes #2948

Open
richard627z opened this issue May 5, 2022 · 9 comments
Open

Wrong cart rotation on slopes #2948

richard627z opened this issue May 5, 2022 · 9 comments
Labels

Comments

@richard627z
Copy link

The minecart passes through the railway when it goes up. It can not go up correctly.
210840

@appgurueu
Copy link
Contributor

  1. Which MTG version?
  2. Steps to reproduce?

@richard627z
Copy link
Author

It is the latest version.

The details are below.

The two minecarts also pass through each other.

It seems like the collision detection problem.

2.mp4

@appgurueu
Copy link
Contributor

The two minecarts also pass through each other.

I believe this is intended; the minecart being incorrectly rotated is definitely not intended.

The cart failing to climb the slope however may be intended: Have you tried pushing the cart harder / a couple more times / while climbing the slope to get it over it? Or using accelerator rails?

@appgurueu appgurueu changed the title Minecart Problem Wrong cart rotation on slopes May 5, 2022
@richard627z
Copy link
Author

Thanks.

I think it will be great if it can act like this in Minecraft. The cart will go back if it can not climb the slope rather than being stuck.

cart.mp4

@MidnightPhantom
Copy link

Same happens with me too

@appgurueu
Copy link
Contributor

I have confirmed this issue.

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented May 24, 2022

The issue description is terrible. Here's the real bug description:

The real bug description

If you punch a cart to move it up towards a slope, but the cart is too slow to take the whole slope, it will stop at the slope (expected) but then it rotates the wrong way (as seen in screenshot).
The cart must be so slow that it stops right at the slope.
If a cart goes the slope upwards at the full speed, it works fine. If the cart fails to take the slope, but returns far enough to go back on the straight level track again (so that is no longer on the slope), it also works fine.
Tested in 5.5.1.

Analysis

I believe the bug happens because the cart internally "turns around" when it stops at the slope. And then the cart is both at the slope but rotated the other way so that it thinks it goes down the slope.

I therefore believe the fix would be to force to believe the cart is going downwards when it is at the slope but at 0 (or near-0) speed. Either that, or make the cart stand upright (pick whatever seems better for you).

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented May 24, 2022

It appears 38307da might have already fixed this. @SmallJoker

@appgurueu
Copy link
Contributor

It appears 38307da might have already fixed this. @SmallJoker

It only partially fixed this; it still looks very wrong and the cart doesn't roll downwards as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants