Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic Screwdriver can Rotate Steel Doors #642

Open
DustyBagel opened this issue Apr 23, 2024 · 5 comments
Open

Sonic Screwdriver can Rotate Steel Doors #642

DustyBagel opened this issue Apr 23, 2024 · 5 comments
Labels

Comments

@DustyBagel
Copy link
Contributor

DustyBagel commented Apr 23, 2024

Nodes like the steel door and trap door can be rotated out of the way with a sonic screwdriver but not with the regular screwdriver. This could be a problem for players that have their stuff protected with these nodes.

@DustyBagel DustyBagel added the Bug label Apr 23, 2024
@DustyBagel DustyBagel changed the title [Security Issue] Sonic Screwdriver can Rotate Protected Nodes [Minor Security Issue] Sonic Screwdriver can Rotate Steel Doors Apr 23, 2024
@SmallJoker
Copy link
Member

The sonic screwdriver does check against area protection. If the player has access to the area, they could also break though walls to get around the door. Thus I don't think this is a bug.

@DustyBagel
Copy link
Contributor Author

Wel, l it isn't a very big issue, but the regular screwdriver doesn't do this, and it would make sense the sonic screwdriver wouldn't too, but you are right. This isn't nearly as big of a problem as I made it out to be. Sorry about that.

@DustyBagel DustyBagel changed the title [Minor Security Issue] Sonic Screwdriver can Rotate Steel Doors Sonic Screwdriver can Rotate Steel Doors Apr 23, 2024
@SmallJoker
Copy link
Member

From what I can see this does not seem to cause any side-effects like broken collision boxes. Unless that happens to be an issue, I think it can be considered a feature. After all, the default screwdriver is much cheaper overall, thus should be less capable to give the sonic screwdriver a purpose.

@Desour
Copy link
Contributor

Desour commented Apr 28, 2024

The issue is that the sonic screwdriver doesn't call on_rotate. This causes a bunch of issues. For example, if you rotate an mtg door, it doesn't rotate the invisible upper part, and you can rotate piston heads, and whatnot.

After all, the default screwdriver is much cheaper overall, thus should be less capable to give the sonic screwdriver a purpose.

The main selling point of the sonic screwdriver is that it doesn't break. And (actually more importantly) the coolness factor, with the sound and the dr. who reference.

@SmallJoker
Copy link
Member

I see. The sonic screwdriver should probably call the optional MTG screwdriver API if that field is present. Unfortunately the doors mod does not implement rotating on its own, which is a bummer.

The API in question:

https://github.com/minetest/minetest_game/blob/master/game_api.txt#L594-L610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants