Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Increase Storage Capacity in Mithril Chests #626

Open
DustyBagel opened this issue Dec 30, 2023 · 12 comments
Open

[Feature Request] Increase Storage Capacity in Mithril Chests #626

DustyBagel opened this issue Dec 30, 2023 · 12 comments

Comments

@DustyBagel
Copy link
Contributor

I have noticed that the gold chest and the mithril chest have the same amount of item slots. This doesn't make sense because of the resources needed to make a mithril chest.

@SmallJoker
Copy link
Member

Copper chest: 12 * 5 = 60 slots
Silver chest: 12 * 6 = 72 slots
Gold chest: 15 * 6 = 90 slots

How many slots should the mithril chest have? You can experiment a bit with the inventory dimensions here:

technic.chests:register("Mithril", {
width = 15,
height = 6,
sort = true,
autosort = true,
infotext = false,
color = false,
locked = false,
})
technic.chests:register("Mithril", {
width = 15,
height = 6,
sort = true,
autosort = true,
infotext = false,
color = false,
locked = true,
})

Make sure that you remove the chest and place it again after the change so that the inventory dimensions are initialized as intended.

Follow-up question: how should the chest be presented to mobile players? The mithril chest is already very tiny to work with. There are the following options: (unless you have more ideas)

  • Scrollbar container (entirely client-side)
  • Buttons to switch between pages (server delay due to formspec update)

@DustyBagel
Copy link
Contributor Author

Well, if formspec size is a concern then one possible solution would be to make the rest of the chests a bit smaller. I will play around with the chest sizes and get back to you. How would you like the changes I make to be submitted? Via pull request or just tell you the sizes as making an entire pull request seems to be unnecessary.

@SmallJoker
Copy link
Member

@DustyBagel I don't have a preference in that regard. Both would allow discussions with others to figure out the optimum balance between the chest sizes.

@cx384
Copy link
Contributor

cx384 commented Jan 11, 2024

I agree that the resource cost of mithril chest makes no sense, but just giving them more slots is a bit uninspiring, since mithril is a magical metal.

Imo it would be much better if the chest could do something special. For example:

  • More items per slot (using count_meta), or hiding slots that have the same item
  • Automatic compressing (crafting 9 ingots onto blocks)
  • Configurable injection functionality
  • Charging/repairing items if placed next to a battery box/tool workshop
  • Automatically taking selected items from the player inventory on punching it
  • ...

@DustyBagel
Copy link
Contributor Author

@cx384 Wait, mithril is a magical metal? I thought it was just fictional.

@cx384
Copy link
Contributor

cx384 commented Jan 12, 2024

OK, calling it a magical metal may be a big stretch, but at least I wouldn't say it's non-magical.
In Tolkien's work it was not explicitly magical, I think.
However, nowadays, it's a widespread material in the fantasy genre, where it sometimes has magical properties.

In regard to whether mithril is magical, technic chests gain abilities when you upgrade them (autosort, infotext, color ...), but when you upgrade from gold to mithril you lose the infotext and color ability.
So I would like to get a new ability instead.

@DustyBagel
Copy link
Contributor Author

Well, we could do what minecraft did with the ender chest but that is an unoriginal idea that other mods have added anyway. Maybe sense mithril is supposed to be really strong, we could make the chest TNT proof.

@OgelGames
Copy link
Contributor

Mithril chests in technic_plus have digilines functionality :)

@DustyBagel
Copy link
Contributor Author

I like the idea of making the stack sizes in the chest bigger. Digilines functionality is a good idea too. What does that do exactaly. I never figured out how digilines works.

@DustyBagel
Copy link
Contributor Author

So, what is happening with this? Are you guys waiting on me to make the changes and create a pull request or is someone else handling it? I am all for giving the mithril chest some kind of special ability, but I have no idea what that should be and I have been pretty busy with other projects so I would appreciate it if someone would please fill me in.

@cx384
Copy link
Contributor

cx384 commented Feb 7, 2024

I think this is still in discussion, I would opt for at least digilines functionality.

So far, there wasn't much opposition to any of the proposed features, so you could make a pull request if you have a concrete implementation that you think will be accepted.

@Desour
Copy link
Contributor

Desour commented Feb 7, 2024

More ideas:

You could also make the inventory one slot bigger for each stack with stackcount 1 that is in the inventory, up until a max size is reached.

Or make it so that if you open the chest with a mtg key to a different mithril chest, you open the inventory of that other chest. (Maybe eat up the key to make it less powerful, or make the key back to a skeleton key.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants