Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish REST driver implementation (some pieces were left out from initial implementation) #306

Open
Tracked by #299
mesembria opened this issue Jan 30, 2025 · 4 comments
Assignees

Comments

@mesembria
Copy link
Contributor

No description provided.

@teodor-yanev
Copy link
Contributor

I need to talk with @JAORMX before picking this up

@teodor-yanev teodor-yanev self-assigned this Feb 3, 2025
@teodor-yanev teodor-yanev moved this from Backlog to In Progress in Planned Work Feb 3, 2025
@teodor-yanev
Copy link
Contributor

teodor-yanev commented Feb 3, 2025

Looking at the TODOs in internal/datasources/rest/handler.go, I do not see any of them being critical for releasing data sources in prod for the time being. They include:

  • implement fallback
  • implement auth (we already discussed that this is not needed for now as we only hit public endpoints in our rules for the time being)
  • add an option to use custom clients and make the timeout configurable (I'm afraid I miss the context here)

cc: @eleftherias @evankanderson

@eleftherias
Copy link
Contributor

I agree that none of those are critical. We can pick them up at a later time.

@teodor-yanev teodor-yanev moved this from In Progress to Backlog in Planned Work Feb 3, 2025
@evankanderson
Copy link
Member

Does this mean that we should enable the datasources feature flag in production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants