Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dead key problem #39

Closed
wants to merge 1 commit into from
Closed

Fix for dead key problem #39

wants to merge 1 commit into from

Conversation

bk
Copy link

@bk bk commented Nov 18, 2020

When the mouse cursor is outside the active urxvt window dead
keys stop working, at least when using ibus. This small fix stops
the tabbedex extension from doing anyting when dead keys are
pressed under these circumstances, which sidesteps the issue.
Fixes #26.

When the mouse cursor is outside the active urxvt window dead
keys stop working, at least when using ibus. This small fix stops
the tabbedex extension from doing anyting when dead keys are
pressed under these circumstances, which sidesteps the issue.
See also mina86#26.
@mina86
Copy link
Owner

mina86 commented Nov 18, 2020

I’m not sure what this actually solves at this point. The dead keys remain non-functional with this commit so does this really improve anything?

@bk
Copy link
Author

bk commented Nov 18, 2020

That's strange. This one-line change solved the issue for my particular config. I'm using urxvt v9.22 on Ubuntu 20.04 - under Gnome 3.36 with the ibus input framework. I have an Icelandic keyboard layout, where the acute accent over the vowels á, é, í, ó, ú and ý (all of which are common in Icelandic) is a dead key. The accent key does not work in urxvt when the tabbedex extension is loaded unless the mouse cursor is over the urxvt window. The problem is not present when using plain urxvt without tabbedex. (It is, however, present with the original tabbed extension, which can be fixed in a similar way).

What is your way of reproducing the issue?

mina86 pushed a commit that referenced this pull request Nov 18, 2020
When the mouse pointer is outside of the terminal window, dead keys
stop working.  When ibus is used, the prompt pops up but once next
key is pressed, no character is inserted to the terminal.  This fixes
that issue.

Unfortunately, the fix only works when ibus is used.  If urxvt is
configured not to utilise it, dead keys remain broken when the mouse
pointer is outside of the terminal window and result.

See: #26
Fixes: #39

[[email protected]: moved check to key_press handler and reworded
 comment and commit message]
@mina86
Copy link
Owner

mina86 commented Nov 18, 2020

Could you verify that code in experimental branch still fixes the issue? Also, do you have any better explanation of how the fix works than what I wrote in the comment in that commit?

@bk
Copy link
Author

bk commented Nov 19, 2020

Yes, the experimental branch version works for me.

I don't have a good explanation for why the problem occurs, but since I once had similar (but more general) problems with dead keys that turned out to be related to an input manager (scim), and because when googling the problem I found several instances of people blaming input managers for such things, my working hypothesis is that the way in which ibus relays keypress events on to programs somehow does not mesh well with urxvt's expectations in that regard.

@mina86 mina86 closed this in 7a95ffa Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead keys require mouse cursor
2 participants