Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug in the code #45

Open
subodh-malgonde opened this issue Apr 24, 2023 · 0 comments
Open

Possible bug in the code #45

subodh-malgonde opened this issue Apr 24, 2023 · 0 comments

Comments

@subodh-malgonde
Copy link

I was just going through the Python code for the host. Found this line:

min/host/min.py

Lines 557 to 558 in 9e87a79

if (self._sn_max - self._sn_max) & 0xff > window_size:
raise AssertionError

self._sn_max - self._sn_max will always be zero and the if condition will always evaluate to False.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@subodh-malgonde