Registry: Implement stateless property (#10)

.github/workflows/build.yml

@@ -19,4 +19,3 @@ jobs:
         uses: ./.github/actions/setup
       - name: Build
         run: yarn build
-

.github/workflows/ci-authorizer.yml

@@ -31,5 +31,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-authorizer test

.github/workflows/ci-deployer.yml

@@ -31,5 +31,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-deployer test

.github/workflows/ci-fee-controller.yml

@@ -31,5 +31,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-fee-controller test

.github/workflows/ci-helpers.yml

@@ -31,5 +31,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-helpers test

.github/workflows/ci-price-oracle.yml

@@ -31,6 +31,8 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-price-oracle test
 
@@ -41,6 +43,8 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test mainnet
         run: yarn workspace @mimic-fi/v3-price-oracle test:mainnet
       - name: Test polygon

.github/workflows/ci-registry.yml

@@ -31,5 +31,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-registry test

.github/workflows/ci-smart-vault.yml

@@ -31,5 +31,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-smart-vault test

.github/workflows/ci-tasks.yml

@@ -31,5 +31,7 @@ jobs:
         uses: actions/checkout@v3
       - name: Set up environment
         uses: ./.github/actions/setup
+      - name: Build
+        run: yarn build
       - name: Test
         run: yarn workspace @mimic-fi/v3-tasks test

packages/deployer/contracts/Deployer.sol

@@ -76,10 +76,12 @@ contract Deployer {
 
     /**
      * @dev Task params
+     * @param custom Whether the implementation is custom or not, if it is it won't be checked with Mimic's Registry
      * @param impl Address of the task implementation to be used
      * @param initializeData Call-data to initialize the new task instance
      */
     struct TaskParams {
+        bool custom;
         address impl;
         bytes initializeData;
     }
@@ -102,7 +104,7 @@ contract Deployer {
      * @dev Deploys a new authorizer instance
      */
     function deployAuthorizer(string memory namespace, string memory name, AuthorizerParams memory params) external {
-        address instance = _deployClone(namespace, name, params.impl);
+        address instance = _deployClone(namespace, name, params.impl, true);
         Authorizer(instance).initialize(params.owners);
         emit AuthorizerDeployed(namespace, name, instance, params.impl);
     }
@@ -111,7 +113,7 @@ contract Deployer {
      * @dev Deploys a new smart vault instance
      */
     function deploySmartVault(string memory namespace, string memory name, SmartVaultParams memory params) external {
-        address payable instance = payable(_deployClone(namespace, name, params.impl));
+        address payable instance = payable(_deployClone(namespace, name, params.impl, true));
         SmartVault(instance).initialize(params.authorizer, params.priceOracle, params.priceFeedParams);
         emit SmartVaultDeployed(namespace, name, instance, params.impl);
     }
@@ -120,20 +122,22 @@ contract Deployer {
      * @dev Deploys a new task instance
      */
     function deployTask(string memory namespace, string memory name, TaskParams memory params) external {
-        address instance = _deployClone(namespace, name, params.impl);
+        address instance = _deployClone(namespace, name, params.impl, !params.custom);
         if (params.initializeData.length > 0) instance.functionCall(params.initializeData, 'DEPLOYER_TASK_INIT_FAILED');
         emit TaskDeployed(namespace, name, instance, params.impl);
     }
 
     /**
      * @dev Deploys a new clone using CREATE3
      */
-    function _deployClone(string memory namespace, string memory name, address implementation)
+    function _deployClone(string memory namespace, string memory name, address implementation, bool check)
         internal
         returns (address)
     {
-        require(registry.isRegistered(implementation), 'DEPLOYER_IMPL_NOT_REGISTERED');
-        require(!registry.isDeprecated(implementation), 'DEPLOYER_IMPL_DEPRECATED');
+        if (check) {
+            require(registry.isRegistered(implementation), 'DEPLOYER_IMPL_NOT_REGISTERED');
+            require(!registry.isDeprecated(implementation), 'DEPLOYER_IMPL_DEPRECATED');
+        }
 
         bytes memory bytecode = abi.encodePacked(
             hex'3d602d80600a3d3981f3363d3d373d3d3d363d73',

packages/deployer/test/Deployer.test.ts

@@ -41,7 +41,7 @@ describe('Deployer', () => {
 
     context('when the implementation is registered', () => {
       beforeEach('register implementation', async () => {
-        await registry.connect(mimic).register('[email protected]', authorizer.address)
+        await registry.connect(mimic).register('[email protected]', authorizer.address, false)
       })
 
       context('when the implementation is not deprecated', () => {
@@ -172,8 +172,8 @@ describe('Deployer', () => {
 
     context('when the implementation is registered', () => {
       beforeEach('register implementations', async () => {
-        await registry.connect(mimic).register('[email protected]', smartVault.address)
-        await registry.connect(mimic).register('[email protected]', PRICE_ORACLE)
+        await registry.connect(mimic).register('[email protected]', smartVault.address, false)
+        await registry.connect(mimic).register('[email protected]', PRICE_ORACLE, true)
       })
 
       context('when the implementation is not deprecated', () => {
@@ -292,10 +292,10 @@ describe('Deployer', () => {
       const FEE_CONTROLLER = '0x0000000000000000000000000000000000000001'
       const WNT = '0x0000000000000000000000000000000000000002'
       const smartVaultImpl = await deploy(ARTIFACTS.SMART_VAULT, [registry.address, FEE_CONTROLLER, WNT])
-      await registry.connect(mimic).register('[email protected]', smartVaultImpl.address)
+      await registry.connect(mimic).register('[email protected]', smartVaultImpl.address, false)
 
       const PRICE_ORACLE = '0x0000000000000000000000000000000000000004'
-      await registry.connect(mimic).register('[email protected]', PRICE_ORACLE)
+      await registry.connect(mimic).register('[email protected]', PRICE_ORACLE, true)
 
       const tx = await deployer.deploySmartVault(namespace, 'smart-vault', {
         impl: smartVaultImpl.address,
@@ -316,7 +316,7 @@ describe('Deployer', () => {
 
     context('when the implementation is registered', () => {
       beforeEach('register implementations', async () => {
-        await registry.connect(mimic).register('[email protected]', task.address)
+        await registry.connect(mimic).register('[email protected]', task.address, false)
       })
 
       context('when the implementation is not deprecated', () => {

packages/registry/contracts/Registry.sol

@@ -27,6 +27,9 @@ contract Registry is IRegistry, Ownable {
     // List of registered implementations
     mapping (address => bool) public override isRegistered;
 
+    // List of stateless implementations
+    mapping (address => bool) public override isStateless;
+
     // List of deprecated implementations
     mapping (address => bool) public override isDeprecated;
 
@@ -42,19 +45,21 @@ contract Registry is IRegistry, Ownable {
      * @dev Creates and registers an implementation
      * @param name Name of the implementation
      * @param code Code of the implementation to create and register
+     * @param stateless Whether the new implementation is considered stateless or not
      */
-    function create(string memory name, bytes memory code) external override onlyOwner {
+    function create(string memory name, bytes memory code, bool stateless) external override onlyOwner {
         address implementation = CREATE3.deploy(keccak256(abi.encode(name)), code, 0);
-        _register(name, implementation);
+        _register(name, implementation, stateless);
     }
 
     /**
      * @dev Registers an implementation
      * @param name Name logged for the implementation
      * @param implementation Address of the implementation to be registered
+     * @param stateless Whether the given implementation is considered stateless or not
      */
-    function register(string memory name, address implementation) external override onlyOwner {
-        _register(name, implementation);
+    function register(string memory name, address implementation, bool stateless) external override onlyOwner {
+        _register(name, implementation, stateless);
     }
 
     /**
@@ -74,12 +79,14 @@ contract Registry is IRegistry, Ownable {
      * @dev Registers an implementation
      * @param name Name of the implementation
      * @param implementation Address of the implementation to be registered
+     * @param stateless Whether the given implementation is considered stateless or not
      */
-    function _register(string memory name, address implementation) internal {
+    function _register(string memory name, address implementation, bool stateless) internal {
         require(implementation != address(0), 'REGISTRY_IMPL_ADDRESS_ZERO');
         require(!isRegistered[implementation], 'REGISTRY_IMPL_ALREADY_REGISTERED');
 
         isRegistered[implementation] = true;
-        emit Registered(implementation, name);
+        isStateless[implementation] = stateless;
+        emit Registered(implementation, name, stateless);
     }
 }

packages/registry/contracts/interfaces/IRegistry.sol

@@ -25,7 +25,7 @@ interface IRegistry {
     /**
      * @dev Emitted every time an implementation is registered
      */
-    event Registered(address indexed implementation, string name);
+    event Registered(address indexed implementation, string name, bool stateless);
 
     /**
      * @dev Emitted every time an implementation is deprecated
@@ -38,6 +38,12 @@ interface IRegistry {
      */
     function isRegistered(address implementation) external view returns (bool);
 
+    /**
+     * @dev Tells whether an implementation is stateless or not
+     * @param implementation Address of the implementation being queried
+     */
+    function isStateless(address implementation) external view returns (bool);
+
     /**
      * @dev Tells whether an implementation is deprecated
      * @param implementation Address of the implementation being queried
@@ -48,15 +54,17 @@ interface IRegistry {
      * @dev Creates and registers an implementation
      * @param name Name of the implementation
      * @param code Code of the implementation to create and register
+     * @param stateless Whether the new implementation is considered stateless or not
      */
-    function create(string memory name, bytes memory code) external;
+    function create(string memory name, bytes memory code, bool stateless) external;
 
     /**
      * @dev Registers an implementation
      * @param name Name of the implementation
      * @param implementation Address of the implementation to be registered
+     * @param stateless Whether the given implementation is considered stateless or not
      */
-    function register(string memory name, address implementation) external;
+    function register(string memory name, address implementation, bool stateless) external;
 
     /**
      * @dev Deprecates an implementation