Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EigenSolver is missing virtual methods used by the LinearSolverConstraintCorrection of SOFA #73

Open
jnbrunet opened this issue Oct 1, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jnbrunet
Copy link
Member

jnbrunet commented Oct 1, 2021

This issue was raised here by Jan.

When one of Caribou's linear solvers is used by a LinearSolverConstraintCorrection of SOFA, the constraints are simply not solved at all. This is because the latter is using some virtual methods that are not implemented in Caribou's EigenSolver (the base class of all Caribou's linear solvers):

  1. sofa::core::behavior::LinearSolver::addJMInvJt(R, J, f)
  2. sofa::core::behavior::LinearSolver::getSystemBaseMatrix()
  3. sofa::core::behavior::LinearSolver::getSystemRHBaseVector()
  4. sofa::core::behavior::LinearSolver::getSystemLHBaseVector()
  5. sofa::core::behavior::LinearSolver::rebuildSystem()
  6. sofa::core::behavior::LinearSolver::init_partial_solve() (optional?)
  7. sofa::core::behavior::LinearSolver::partial_solve(m_indices, f_indices) (optional?)

I've started a branch here with a scene example that does not work, but should. It can be used to validate that this issue is resolved.

cc @hugtalbot @Sidaty1

@jnbrunet jnbrunet added the bug Something isn't working label Oct 1, 2021
@jnbrunet jnbrunet self-assigned this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant