Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent wallet transactions state #607

Open
deevope opened this issue Apr 18, 2021 · 1 comment
Open

inconsistent wallet transactions state #607

deevope opened this issue Apr 18, 2021 · 1 comment

Comments

@deevope
Copy link
Contributor

deevope commented Apr 18, 2021

Is your feature request related to a problem? Please describe.
After a long reorg that doesn't mine any transactions (double-spend...) which has been received and directly spent during the reorg, these transactions are in inconsistent state. We don't check whether they are still confirmed or not, eg we don't track the kernel. That's a big issue for wallets handling a lot of transactions volume.

Describe the solution you'd like
If a reorg is detected and our latest block scan is included in the stale blocks, check the kernel of the confirmed received/spent transactions and change their status to unconfirmed if they were not mined again at the end of the reorg.

@phyro
Copy link
Member

phyro commented Jun 7, 2021

I think that's something that we might want to address, otherwise the only option is a scan from scratch which might lose any local data that is kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants