Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for config endpoint #129

Open
ofhouse opened this issue Apr 27, 2022 · 0 comments · May be fixed by #145
Open

Add option for config endpoint #129

ofhouse opened this issue Apr 27, 2022 · 0 comments · May be fixed by #145
Labels
enhancement New feature or request

Comments

@ofhouse
Copy link
Member

ofhouse commented Apr 27, 2022

Motivation

Since the Terraform for Next.js module will support multiple deployments in the future, the image config can no longer passed as static values to this submodule.

Idea

A new variable should be added where an config endpoint can be defined.
The endpoint is then passed as environment variable to the Lambda.
From the lambda then the image config is requested from the endpoint.
The full hostname (including subdomains, e.g. sub.example.com) is sent as parameter to the endpoint.

The endpoint then returns a full Next.js image config that is then cached & used inside the Lambda to process the image.
The config from the endpoint overrides the settings that are made through the Terraform variables.

@ofhouse ofhouse added the enhancement New feature or request label Apr 27, 2022
@ofhouse ofhouse linked a pull request Aug 21, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant