Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU type not saved if statistics already saved. #77

Open
bouthilx opened this issue Oct 12, 2023 · 0 comments
Open

GPU type not saved if statistics already saved. #77

bouthilx opened this issue Oct 12, 2023 · 0 comments

Comments

@bouthilx
Copy link
Member

for entry in tqdm(scraper):
    saved = False
    if not ignore_statistics:
        saved = entry.statistics(recompute=True, save=True) is not None

    # Get GPU info for this job.
    update_allocated_gpu_type(cluster, entry)

    if not saved:
        collection.save_job(entry)
print(f"Saved {len(scraper)} entries.")

The part collection.save_job(entry) will not be called if entry.statistics returns True. The function update_allocated_gpu_type should also verify if it had made any modification and return this as a bool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant