Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version, compatible with MikroORM V6 #155

Closed
darky opened this issue Jan 8, 2024 · 6 comments
Closed

Bump version, compatible with MikroORM V6 #155

darky opened this issue Jan 8, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@darky
Copy link

darky commented Jan 8, 2024

No description provided.

@darky darky added the enhancement New feature or request label Jan 8, 2024
@B4nan
Copy link
Member

B4nan commented Jan 8, 2024

Current version is already compatible.

@B4nan B4nan closed this as completed Jan 8, 2024
@darky
Copy link
Author

darky commented Jan 8, 2024

Not exactly
Peer dependency error
https://github.com/mikro-orm/nestjs/blob/master/package.json#L43

@B4nan
Copy link
Member

B4nan commented Jan 8, 2024

I dont see any peer dependency error (https://github.com/mikro-orm/nestjs-realworld-example-app), ^6.0.0-dev already supports any 6.0 stable version.

image image

See https://semver.npmjs.com/

@darky
Copy link
Author

darky commented Jan 8, 2024

Maybe this calculator don't work perfectly, I have error during npm install
Anyway I create PR #156

@B4nan
Copy link
Member

B4nan commented Jan 8, 2024

as i said, i dont see any errors, tried with npm and yarn in the realworld example app, no issues there

anyway, i will ship v6 of this package too later this week (maybe even today). if you see issues with peer deps, you can always just use --force to get around them.

@darky
Copy link
Author

darky commented Jan 8, 2024

you can always just use --force to get around them

Already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants