Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected input(s) 'comment' #1186

Open
kjetilk-kontali opened this issue Sep 16, 2024 · 6 comments
Open

Unexpected input(s) 'comment' #1186

kjetilk-kontali opened this issue Sep 16, 2024 · 6 comments

Comments

@kjetilk-kontali
Copy link

kjetilk-kontali commented Sep 16, 2024

Hi,

I've added the GitHub Action as follows:

- name: Publish Test Report for Integration Tests
  uses: mikepenz/action-junit-report@v4
  if: always()
  with:
    report_paths: '.test-results/*.xml'
    detailed_summary: true
    comment: true
    include_passed: true

But when the action is run, I get the following warning:
Warning: Unexpected input(s) 'comment', valid inputs are ['token', 'github_token', 'report_paths', 'test_files_prefix', 'exclude_sources', 'suite_regex', 'annotate_only', 'check_annotations', 'update_check', 'check_name', 'commit', 'fail_on_failure', 'require_tests', 'require_passed_tests', 'include_passed', 'check_title_template', 'summary', 'check_retries', 'transformers', 'job_summary', 'detailed_summary', 'annotate_notice', 'follow_symlink', 'job_name', 'annotations_limit', 'truncate_stack_traces']

I can see from the docs (and the source code) that comment should be a valid input argument to the GH Action, so why am I getting this warning?

@mikepenz
Copy link
Owner

This feature is a v5 feature and is currently only available in the latest alphas:

@mikepenz
Copy link
Owner

You can see the @v4 README.md here: https://github.com/mikepenz/action-junit-report/tree/v4

@kjetilk-kontali
Copy link
Author

Ah! That figures :)

PS. Might be an idea to mark the input args in the "Inputs" table with the version they're valid in? (e.g. ">5.0")

@wmcnamee-coreweave
Copy link

just ran into the same thing. Oops! Can I try out v5 some way?

@mikepenz
Copy link
Owner

@PoqaTJ
Copy link

PoqaTJ commented Oct 19, 2024

Just ran into this as well, for both comment and updateComment. The docs should reflect what's available, not what's planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants