Replies: 1 comment 4 replies
-
The non-crucial packages are installed that way. The experience should be as smooth as possible. Giving an error if it is automatable is not an option 😄 |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I noticed that dependencies are automatically installed via TestRequirements. I am not sure this is the best idea.
It compromises the users own package installation without their control which might not be desired.
I can see why something like this is needed though. We want to be able to dynamically set dependencies like
onnxruntime
andonnxruntime-gpu
, as well as not install dependencies that might not be needed by the user (e.g.nvidia-tensorrt
).It seems like there are ongoing discussions to support something like this in setuptools here.
I would instead propose to give a LOG error message to the user when they want to use a feature like ReIDDetectMultiBackend with a non-pytorch weights file.
Example:
Beta Was this translation helpful? Give feedback.
All reactions