🤖 Merge PR DefinitelyTyped#57357 fix(dns2): support for CNAME responses by @rschick

Author: rschick

types/dns2/dns2-tests.ts

@@ -6,45 +6,55 @@ import DNS = require('dns2');
 const dns = new DNS();
 
 (async () => {
-  const result = await dns.resolveA('google.com');
-  console.log(result.answers);
+    const result = await dns.resolveA('google.com');
+    console.log(result.answers);
+
+    const result2 = await dns.resolveCNAME('google.com');
+    console.log(result2.answers.filter(answer => answer.domain));
 })();
 
 const { Packet } = DNS;
 
 const server = DNS.createServer({
-  udp: true,
-  handle: (request, send, rinfo) => {
-    const response = Packet.createResponseFromRequest(request);
-    const [ question ] = request.questions;
-    const { name } = question;
-    response.answers.push({
-      name,
-      type: Packet.TYPE.A,
-      class: Packet.CLASS.IN,
-      ttl: 300,
-      address: '8.8.8.8'
-    });
-    send(response);
-  }
+    udp: true,
+    handle: (request, send, rinfo) => {
+        const response = Packet.createResponseFromRequest(request);
+        const [question] = request.questions;
+        const { name } = question;
+        response.answers.push({
+            name,
+            type: Packet.TYPE.A,
+            class: Packet.CLASS.IN,
+            ttl: 300,
+            address: '8.8.8.8',
+        });
+        response.answers.push({
+            name,
+            type: Packet.TYPE.CNAME,
+            class: Packet.CLASS.IN,
+            ttl: 300,
+            domain: 'another-name.example.com',
+        });
+        send(response);
+    },
 });
 
 server.on('request', (request, response, rinfo) => {
-  console.log(request.header.id, request.questions[0]);
+    console.log(request.header.id, request.questions[0]);
 });
 
 server.listen({ udp: 5333 });
 
 const udpServer = new DNS.UDPServer((request, send, rinfo) => {
-  const response = Packet.createResponseFromRequest(request);
-  send(response);
+    const response = Packet.createResponseFromRequest(request);
+    send(response);
 });
 
-udpServer.listen(5353, "127.0.0.1");
+udpServer.listen(5353, '127.0.0.1');
 
 const tcpServer = DNS.createTCPServer((request, send, rinfo) => {
-  const response = Packet.createResponseFromRequest(request);
-  send(response);
+    const response = Packet.createResponseFromRequest(request);
+    send(response);
 });
 
-tcpServer.listen(5454, "127.0.0.1");
+tcpServer.listen(5454, '127.0.0.1');

types/dns2/index.d.ts

@@ -70,7 +70,8 @@ declare namespace DNS {
         type: number;
         class: number;
         ttl: number;
-        address: string;
+        address?: string;
+        domain?: string;
     }
 
     type DnsHandler = (
@@ -87,11 +88,7 @@ declare class DnsServer extends EventEmitter {
         doh?: net.AddressInfo;
     };
 
-    listen(ports: {
-        udp?: number,
-        tcp?: number,
-        doh?: number
-    }): Promise<void>;
+    listen(ports: { udp?: number; tcp?: number; doh?: number }): Promise<void>;
 
     close(): Promise<void>;
 }
@@ -106,12 +103,7 @@ declare class TcpDnsServer extends net.Server {
 }
 
 declare class DNS {
-    static createServer(options: {
-        udp?: boolean,
-        tcp?: boolean,
-        doh?: boolean,
-        handle: DNS.DnsHandler
-    }): DnsServer;
+    static createServer(options: { udp?: boolean; tcp?: boolean; doh?: boolean; handle: DNS.DnsHandler }): DnsServer;
 
     static Packet: typeof Packet;