Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browseReleaseGroup parameter order #37

Open
lachlan-00 opened this issue Jan 25, 2024 · 1 comment
Open

browseReleaseGroup parameter order #37

lachlan-00 opened this issue Jan 25, 2024 · 1 comment

Comments

@lachlan-00
Copy link

lachlan-00 commented Jan 25, 2024

getting this php error semi-regularly

2 tests triggered 3 PHP deprecations:

1) /home/scrutinizer/build/vendor/mikealmond/musicbrainz/src/MusicBrainz/MusicBrainz.php:492
Optional parameter $limit declared before required parameter $includes is implicitly treated as a required parameter

2) /home/scrutinizer/build/vendor/mikealmond/musicbrainz/src/MusicBrainz/MusicBrainz.php:0
Optional parameter $offset declared before required parameter $includes is implicitly treated as a required parameter

https://github.com/mikealmond/MusicBrainz/blob/98d1aa1c57dbb609d71db9d3d1487a5729f149de/src/MusicBrainz/MusicBrainz.php#L497C8-L497C25

public function browseReleaseGroup(
        $entity,
        $mbid,
        $limit = 25,
        $offset = null,
        array $includes,
        $releaseType = array()
    ) {

probably just need to add the array?

array $includes = array(),

@lachlan-00 lachlan-00 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
@lachlan-00
Copy link
Author

sorry i closed thinking i'd made a mistake

@lachlan-00 lachlan-00 reopened this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant