Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing valid include for lookup of recording #35

Open
SePHTaN opened this issue May 21, 2021 · 0 comments
Open

Missing valid include for lookup of recording #35

SePHTaN opened this issue May 21, 2021 · 0 comments

Comments

@SePHTaN
Copy link

SePHTaN commented May 21, 2021

According to https://musicbrainz.org/doc/MusicBrainz_API isrcs is an allowed entitity when doing a lookup of recordings:

Subqueries
/ws/2/recording artists, releases, isrcs, url-rels
But in Musicbrainz.php this entity is missing in the ValidIncludes array for the recording entity.

It would be great if you add it so it can be used for reverse identifying an track and the associated mb_recordingid as the isrc is more often in file tags than mb id's.
I can also fork your repository, patch and do a pull request if that is your preferred way.

Thanks in advance
Stephan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant