Skip to content

False negative for crates.io #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
korken89 opened this issue Aug 26, 2018 · 3 comments
Closed

False negative for crates.io #17

korken89 opened this issue Aug 26, 2018 · 3 comments

Comments

@korken89
Copy link
Contributor

korken89 commented Aug 26, 2018

Hi, I have identified a false negative on the following project: https://github.com/rust-embedded/cortex-m-rt
Would it be possible to fix this? I have no idea why it is failing though as if you copy the link it works fine.

Thanks!

Output:

$ mdcheckr README.md                                                                                                                  [12:54:15]
Checking README.md ..
- Link https://crates.io/crates/cortex-m-rt [ FAIL ]
Warning:README.md:1:Broken link 'https://crates.io/crates/cortex-m-rt'
- Link https://crates.io/crates/cortex-m-rt [ FAIL ]
Warning:README.md:1:Broken link 'https://crates.io/crates/cortex-m-rt'
- Link https://github.com/rust-embedded/wg#the-cortex-m-team [ OK ]
- Link https://docs.rs/cortex-m-rt [ OK ]
- Link LICENSE-APACHE [ OK ]
- Link http://www.apache.org/licenses/LICENSE-2.0 [ OK ]
- Link LICENSE-MIT [ OK ]
- Link http://opensource.org/licenses/MIT [ OK ]
- Link CODE_OF_CONDUCT.md [ OK ]
- Link https://github.com/rust-embedded/wg#the-cortex-m-team [ OK ]
- Image https://img.shields.io/crates/v/cortex-m-rt.svg [ OK ]
- Image https://img.shields.io/crates/d/cortex-m-rt.svg [ OK ]
Done, with 2 problems(s) found.
@korken89 korken89 changed the title False positive False positive for crates.io Aug 26, 2018
@korken89
Copy link
Contributor Author

The issue seems to be in check_link(), the curl gets a 404 error even though the site exists.

@korken89 korken89 changed the title False positive for crates.io False negative for crates.io Aug 26, 2018
@mike42
Copy link
Owner

mike42 commented Jan 30, 2019

I'll close this as fixed, though it is a site issue in my view.

See also comments @ rust-lang/crates.io#788

@mike42 mike42 closed this as completed Jan 30, 2019
@korken89
Copy link
Contributor Author

No problem, it was fixed in PR #18 as well - I should have closed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants