-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(l10n): Files are not parsed correctly leading to defect entries at Transifex #2
Comments
@nickvergessen Any ideas? |
Try single quotes? But yeah seems the regex is too greedy |
Can I do something for this? |
For now: nickv@nickv-desktop:~/Nextcloud/Repositories/rolls$ git diff
diff --git a/src/components/CommentsBox.vue b/src/components/CommentsBox.vue
index 9ada69a..844f60d 100644
--- a/src/components/CommentsBox.vue
+++ b/src/components/CommentsBox.vue
@@ -22,7 +22,7 @@
</template>
<template #subname>
<i v-if="newCommenEditMode === comment['oc:id']">
- {{ t("rolls", "Editing") }}: {{ comment["oc:message"] }}
+ {{ t('rolls', 'Editing') }}: {{ comment["oc:message"] }}
</i>
<span v-else>
{{ comment["oc:message"] }}
@@ -33,13 +33,13 @@
<template #icon>
<IconEdit :size="20" />
</template>
- {{ t("comments", "Edit comment") }}
+ {{ t('comments", 'Edit comment') }}
</NcActionButton>
<NcActionButton @click="() => removeComment(comment)">
<template #icon>
<Delete :size="20" />
</template>
- {{ t("comments", "Delete comment") }}
+ {{ t('comments', 'Delete comment') }}
</NcActionButton>
</template>
</NcListItem>
@@ -77,10 +77,10 @@
<Send :size="20" v-if="submitCommentStatus === PROMISE_STATUS.done" />
<NcLoadingIcon :size="20" v-else />
</template>
- {{ newCommenEditMode === null ? t("rolls", "Add") : t("rolls", "Update") }}
+ {{ newCommenEditMode === null ? t('rolls', 'Add') : t('rolls', 'Update') }}
</NcButton>
<NcButton type="tertiary-no-background" @click="discardEditing" v-if="newCommenEditMode !== null">
- {{ t("rolls", "Discard") }}
+ {{ t('rolls', 'Discard') }}
</NcButton>
</div>
</form> Should fix it. But I will try to fix the tool |
Fix is in nextcloud/docker-ci#663 |
Tool has been updated, and it seems to work as it dropped the invalid strings: |
Perfect and fast work. Gracias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rolls/src/components/CommentsBox.vue
Line 25 in 73438f9
rolls/src/components/CommentsBox.vue
Line 80 in 73438f9
Result at Transifex:
The text was updated successfully, but these errors were encountered: