Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(l10n): Files are not parsed correctly leading to defect entries at Transifex #2

Closed
rakekniven opened this issue Sep 6, 2024 · 7 comments · Fixed by nextcloud/docker-ci#663

Comments

@rakekniven
Copy link
Contributor

rakekniven commented Sep 6, 2024

{{ t("rolls", "Editing") }}: {{ comment["oc:message"] }}

{{ newCommenEditMode === null ? t("rolls", "Add") : t("rolls", "Update") }}

Result at Transifex:

Bildschirmfoto 2024-09-06 um 16 32 58
@rakekniven
Copy link
Contributor Author

@nickvergessen Any ideas?

@nickvergessen
Copy link

Try single quotes? But yeah seems the regex is too greedy

@mijorus
Copy link
Owner

mijorus commented Sep 9, 2024

Can I do something for this?

@nickvergessen
Copy link

For now:

nickv@nickv-desktop:~/Nextcloud/Repositories/rolls$ git diff
diff --git a/src/components/CommentsBox.vue b/src/components/CommentsBox.vue
index 9ada69a..844f60d 100644
--- a/src/components/CommentsBox.vue
+++ b/src/components/CommentsBox.vue
@@ -22,7 +22,7 @@
                                                </template>
                                                <template #subname>
                                                        <i v-if="newCommenEditMode === comment['oc:id']">
-                                                               {{ t("rolls", "Editing") }}: {{ comment["oc:message"] }}
+                                                               {{ t('rolls', 'Editing') }}: {{ comment["oc:message"] }}
                                                        </i>
                                                        <span v-else>
                                                                {{ comment["oc:message"] }}
@@ -33,13 +33,13 @@
                                                                <template #icon>
                                                                        <IconEdit :size="20" />
                                                                </template>
-                                                               {{ t("comments", "Edit comment") }}
+                                                               {{ t('comments", 'Edit comment') }}
                                                        </NcActionButton>
                                                        <NcActionButton @click="() => removeComment(comment)">
                                                                <template #icon>
                                                                        <Delete :size="20" />
                                                                </template>
-                                                               {{ t("comments", "Delete comment") }}
+                                                               {{ t('comments', 'Delete comment') }}
                                                        </NcActionButton>
                                                </template>
                                        </NcListItem>
@@ -77,10 +77,10 @@
                                                        <Send :size="20" v-if="submitCommentStatus === PROMISE_STATUS.done" />
                                                        <NcLoadingIcon :size="20" v-else />
                                                </template>
-                                               {{ newCommenEditMode === null ? t("rolls", "Add") : t("rolls", "Update") }}
+                                               {{ newCommenEditMode === null ? t('rolls', 'Add') : t('rolls', 'Update') }}
                                        </NcButton>
                                        <NcButton type="tertiary-no-background" @click="discardEditing" v-if="newCommenEditMode !== null">
-                                               {{ t("rolls", "Discard") }}
+                                               {{ t('rolls', 'Discard') }}
                                        </NcButton>
                                </div>
                        </form>

Should fix it.

But I will try to fix the tool

@nickvergessen
Copy link

Fix is in nextcloud/docker-ci#663
Funny that apparently no one ever had 2 translations in the same line of a vue file

@nickvergessen
Copy link

Tool has been updated, and it seems to work as it dropped the invalid strings:
10f8d8b

@rakekniven
Copy link
Contributor Author

Perfect and fast work. Gracias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants