Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect download status indicator progess in the library #678

Closed
6 tasks done
WeepingClown13 opened this issue Apr 18, 2024 · 6 comments
Closed
6 tasks done

incorrect download status indicator progess in the library #678

WeepingClown13 opened this issue Apr 18, 2024 · 6 comments
Labels
Bug Something isn't working

Comments

@WeepingClown13
Copy link

WeepingClown13 commented Apr 18, 2024

Steps to reproduce

This has been happening for the first time, and all that's been done is try to download the latest chapter (chapter 339) of unOrdinary (mangasee extension)

Expected behavior

Progress of download is correctly shown everywhere.

Actual behavior

The download status is shown as full on the download button for unOrdinary chapter 339 once you click unOrdinary in the library. But it is still downloading and only about 80% complete. The downloads section as well as the notification shows the correct progress.

This behaviour does persist upon closing and restarting the app.

Screenshot_20240418_163630_Mihon
Screenshot_20240418_163633_Mihon

Crash logs

No response

Mihon version

0.16.5

Android version

Android 13

Device

Samsung Galaxy S20 FE 5G

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.5.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@WeepingClown13 WeepingClown13 added the Bug Something isn't working label Apr 18, 2024
@ToxicMushroom
Copy link

I'm also on 0.16.5 and have seen the same issue,
I think the stroke size is just way too big on the download progress indicator, see video:

screen-20240420-165413.mp4

@MajorTanya
Copy link
Contributor

I'm also on 0.16.5 and have seen the same issue,
I think the stroke size is just way too big on the download progress indicator, see video:

screen-20240420-165413.mp4

That graphical glitch is unrelated to the issue at hand and already solved in the preview of Mihon, just not in stable yet.

@ToxicMushroom
Copy link

Sorry, I think I read through it too fast the first time, it looked quite identical to the issue I experienced.

I tried reproducing this issue but am failing to do so, all icons and indicators are synced for me when navigating between the manga view/download view/notification.

As for

The download status is shown as full on the download button for unOrdinary chapter 339 once you click unOrdinary in the library.

The second screenshot you attached is not full (No checkmark and slight purple on the top left of the icon).

@WeepingClown13
Copy link
Author

@ToxicMushroom sure, that makes sense. But regardless I'd say it is not moving symmetrically, and nor is the result intuitive (as you can see from how I described it as full).

@MajorTanya
Copy link
Contributor

@ToxicMushroom sure, that makes sense. But regardless I'd say it is not moving symmetrically, and nor is the result intuitive (as you can see from how I described it as full).

The "done" state is always marked with a checkmark in a filled circle, whereas the in-progress download is marked with a slowly filling (clockwise) circle with the download icon on it.

As for the "symmetrical movement" you mention, I think it's difficult to judge whether a linear progress bar and a filling circle are in sync visually, especially with a chapter with many pages. I'm certain the code updating the progress on each of them is linked to the same download process with the same progress data.

The perceived desync might be down to the graphical glitch I mentioned in my previous comment, which is an unfortunate side effect of our rushed update for the Pixel phone crash loop, when we forgot to include the relevant graphical fix in the release as well.

If you're up for it, I'd like you to try the Mihon Preview version and see if the difference in progress marking that you're seeing still persists.

You can get it here: https://github.com/mihonapp/mihon-preview

Use the same source, series, and chapter for best reproduction

@WeepingClown13
Copy link
Author

@MajorTanya confirmed that it is indeed fixed in the preview. Guess it's the fat stroke size that's the culprit afterall? Anyway, thanks for the update.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants