-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect download status indicator progess in the library #678
Comments
I'm also on 0.16.5 and have seen the same issue, screen-20240420-165413.mp4 |
That graphical glitch is unrelated to the issue at hand and already solved in the preview of Mihon, just not in stable yet. |
Sorry, I think I read through it too fast the first time, it looked quite identical to the issue I experienced. I tried reproducing this issue but am failing to do so, all icons and indicators are synced for me when navigating between the manga view/download view/notification. As for
The second screenshot you attached is not full (No checkmark and slight purple on the top left of the icon). |
@ToxicMushroom sure, that makes sense. But regardless I'd say it is not moving symmetrically, and nor is the result intuitive (as you can see from how I described it as full). |
The "done" state is always marked with a checkmark in a filled circle, whereas the in-progress download is marked with a slowly filling (clockwise) circle with the download icon on it. As for the "symmetrical movement" you mention, I think it's difficult to judge whether a linear progress bar and a filling circle are in sync visually, especially with a chapter with many pages. I'm certain the code updating the progress on each of them is linked to the same download process with the same progress data. The perceived desync might be down to the graphical glitch I mentioned in my previous comment, which is an unfortunate side effect of our rushed update for the Pixel phone crash loop, when we forgot to include the relevant graphical fix in the release as well. If you're up for it, I'd like you to try the Mihon Preview version and see if the difference in progress marking that you're seeing still persists. You can get it here: https://github.com/mihonapp/mihon-preview Use the same source, series, and chapter for best reproduction |
@MajorTanya confirmed that it is indeed fixed in the preview. Guess it's the fat stroke size that's the culprit afterall? Anyway, thanks for the update. |
Steps to reproduce
This has been happening for the first time, and all that's been done is try to download the latest chapter (chapter 339) of unOrdinary (mangasee extension)
Expected behavior
Progress of download is correctly shown everywhere.
Actual behavior
The download status is shown as full on the download button for unOrdinary chapter 339 once you click unOrdinary in the library. But it is still downloading and only about 80% complete. The downloads section as well as the notification shows the correct progress.
This behaviour does persist upon closing and restarting the app.
Crash logs
No response
Mihon version
0.16.5
Android version
Android 13
Device
Samsung Galaxy S20 FE 5G
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: