From c2620bfc4f948dc4b72d2442566cf11319910db5 Mon Sep 17 00:00:00 2001
From: Roshan Varughese <40583749+Animeboynz@users.noreply.github.com>
Date: Wed, 18 Sep 2024 23:53:06 +1200
Subject: [PATCH] i18n

---
 .../kanade/presentation/more/onboarding/PermissionStep.kt | 8 ++++----
 .../more/settings/screen/SettingsSecurityScreen.kt        | 4 ++--
 i18n/src/commonMain/moko-resources/base/strings.xml       | 6 ++++++
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt b/app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt
index 48a4693354..8bf7e71825 100644
--- a/app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt
+++ b/app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt
@@ -117,8 +117,8 @@ internal class PermissionStep : OnboardingStep {
             )
 
             PermissionItem(
-                title = "Send crash logs",//i18n later
-                subtitle = "Send anonymised crash logs to the developers",
+                title = stringResource(MR.strings.onboarding_permission_crashlytics),
+                subtitle = stringResource(MR.strings.onboarding_permission_crashlytics_description),
                 granted = allowCrashLogs,
                 onButtonClick = {
                     // Toggle the granted state
@@ -128,8 +128,8 @@ internal class PermissionStep : OnboardingStep {
             )
 
             PermissionItem(
-                title = "Allow analytics",//i18n later
-                subtitle = "Send anonymized usage data to improve app features.",
+                title = stringResource(MR.strings.onboarding_permission_analytics),
+                subtitle = stringResource(MR.strings.onboarding_permission_analytics_description),
                 granted = allowAnalytics,
                 onButtonClick = {
                     // Toggle the granted state
diff --git a/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsSecurityScreen.kt b/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsSecurityScreen.kt
index 645298c5d7..768f5e24cb 100644
--- a/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsSecurityScreen.kt
+++ b/app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsSecurityScreen.kt
@@ -67,11 +67,11 @@ object SettingsSecurityScreen : SearchableSettings {
             ),
             Preference.PreferenceItem.SwitchPreference(
                 pref = securityPreferences.crashlytics(),
-                title = "Allow sharing crash logs with devs",
+                title = stringResource(MR.strings.share_crash_logs),
             ),
             Preference.PreferenceItem.SwitchPreference(
                 pref = securityPreferences.analytics(),
-                title = "Allow sharing analytics data",
+                title = stringResource(MR.strings.share_analytics),
             ),
             Preference.PreferenceItem.SwitchPreference(
                 pref = securityPreferences.hideNotificationContent(),
diff --git a/i18n/src/commonMain/moko-resources/base/strings.xml b/i18n/src/commonMain/moko-resources/base/strings.xml
index 035047acd1..a35187b9a0 100644
--- a/i18n/src/commonMain/moko-resources/base/strings.xml
+++ b/i18n/src/commonMain/moko-resources/base/strings.xml
@@ -190,6 +190,10 @@
     <string name="onboarding_permission_notifications_description">Get notified for library updates and more.</string>
     <string name="onboarding_permission_ignore_battery_opts">Background battery usage</string>
     <string name="onboarding_permission_ignore_battery_opts_description">Avoid interruptions to long-running library updates, downloads, and backup restores.</string>
+    <string name="onboarding_permission_crashlytics">Send crash logs</string>
+    <string name="onboarding_permission_crashlytics_description">Send anonymised crash logs to the developers.</string>
+    <string name="onboarding_permission_analytics">Allow analytics</string>
+    <string name="onboarding_permission_analytics_description">Send anonymized usage data to improve app features.</string>
     <string name="onboarding_permission_action_grant">Grant</string>
     <string name="onboarding_guides_new_user">New to %s? We recommend checking out the getting started guide.</string>
     <string name="onboarding_guides_returning_user">Reinstalling %s?</string>
@@ -246,6 +250,8 @@
     <string name="lock_when_idle">Lock when idle</string>
     <string name="lock_always">Always</string>
     <string name="lock_never">Never</string>
+    <string name="share_crash_logs">Allow sharing crash logs with devs</string>
+    <string name="share_analytics">Allow sharing analytics data</string>
     <string name="hide_notification_content">Hide notification content</string>
     <string name="secure_screen">Secure screen</string>
     <string name="secure_screen_summary">Secure screen hides app contents when switching apps and block screenshots</string>