Skip to content

Make this the recommended replacement for flask-sockets? #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmorshea opened this issue Mar 17, 2022 · 7 comments
Closed

Make this the recommended replacement for flask-sockets? #22

rmorshea opened this issue Mar 17, 2022 · 7 comments
Labels
question Further information is requested

Comments

@rmorshea
Copy link

rmorshea commented Mar 17, 2022

The popular flask-sockets project has recently been archived. It seems like this project should be its spiritual successor.

@edmorley, would it be appropriate to direct people to this project given that no one seems to have forked flask-sockets in order to continue maintaining it?

@miguelgrinberg
Copy link
Owner

Let me know if you have any questions.

@miguelgrinberg miguelgrinberg added the question Further information is requested label Mar 17, 2022
@rmorshea rmorshea changed the title Make this the recommended replacement for flask-sockets Make this the recommended replacement for flask-sockets? Mar 17, 2022
@edmorley
Copy link

@rmorshea Hi! Sorry for the delayed reply.

I've added a link to this repo from from the description on https://github.com/heroku-python/flask-sockets and also as a comment on heroku-python/flask-sockets#85.

Thank you for letting me know :-)

@rmorshea
Copy link
Author

Great! Will close now.

@nmz787-intel
Copy link

nmz787-intel commented Jun 8, 2022

what's the advantage of this over flask-sockets? I just got that working for my app with a proof of concept websocket:socket proxy for enabling the noVNC client in the browser. I'm wondering if this has any performance benefits that might help my VNC framerate. I'm using this to serve my Flask app, if that helps gevent.pywsgi.WSGIServer

@miguelgrinberg
Copy link
Owner

miguelgrinberg commented Jun 8, 2022

what's the advantage of this over flask-sockets?

Mainly that this is a maintained package, while flask-sockets is not.

Flask-Sock supports gevent, but that is not the only option, you have a few more ways to deploy your server, including one that uses standard Gunicorn threads instead of greenlets.

@nmz787-intel
Copy link

so in terms of performance, there's no advantage? Regarding gunicorn and greenlets, I don't really know the difference. Would one be more performant with respect to websocket handling? I'm not expecting more than 10 users... and even if my app is wildly popular, I doubt it would ever see more than a few hundred people at a time... and that's gonna take years to reach, in which time refactoring would be a definitely plan.

@miguelgrinberg
Copy link
Owner

The performance of your application will be largely dictated by the code that you write, not by the framework. If you are really interested in having a detailed comparison of performance between these two packages you will have to code your application in a way that allows you to switch, and then measure the performance and compare. Generic performance numbers are very misleading, and besides, Flask-Sockets has been abandoned for years, even if it was faster it is not a good idea to use it due to being unmaintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants