Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ffmpeg #23

Open
mifi opened this issue Apr 28, 2020 · 11 comments
Open

Include ffmpeg #23

mifi opened this issue Apr 28, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@mifi
Copy link
Owner

mifi commented Apr 28, 2020

Might add the ffmpeg-static dependency, then no need for system ffmpeg. (with an option to use a custom ffmpeg path)
But it does not work on raspberry pi, need to see if it crashes npm install or what happens

@mifi mifi added the enhancement New feature or request label Apr 28, 2020
@chapmanjacobd
Copy link
Contributor

looks like ffprobe is separate

eugeneware/ffmpeg-static#19

??

https://github.com/joshwnj/ffprobe-static

@mifi
Copy link
Owner Author

mifi commented May 3, 2020

Yeah, I'm thinking about building a reusable ffmpeg GitHub Action and a repository that can build ffmpeg for many platforms in many different variants and allow users to fork the repo for their own build configuration, but it's kind of a big job.

@chapmanjacobd
Copy link
Contributor

looks like someone has done something similar before:

https://github.com/vot/ffbinaries-api
https://github.com/vot/ffbinaries-node

@mifi
Copy link
Owner Author

mifi commented May 3, 2020

I found that one too, but there seems to be some issues with those builds not really being static builds. I haven't tried them myself and I'm not sure where he gets the builds from, but I think that the official builds from ffmpeg.org are preferred because they are well tested by a lot of people.
And it seems kind of abandoned, also it doesn't have the latest 4.2.2 version: https://github.com/vot/ffbinaries-prebuilt/releases

@chapmanjacobd
Copy link
Contributor

oh... for some reason I thought this repo https://github.com/vot/ffbinaries-api included the code for automatically compiling from nightly builds or something :/

@mifi
Copy link
Owner Author

mifi commented May 4, 2020

no. it just contains references to downloads from the other repo. So the question is, how are the ffmpeg-prebuilt being built. I've created an issue for that

@maksym-plotnikov
Copy link

maksym-plotnikov commented Nov 27, 2020

@mifi since You're discussing FFMPEG builds we're using these: https://johnvansickle.com/ffmpeg/
And they're always bringing a warning to console because editly complains on
'Unknown version string'
It's because they don't have same build string as official FFMPEG builds (e.g. ffmpeg version N-50742-ga7245adee3-static https://johnvansickle.com/ffmpeg/....
Can You please take a look on these?

@mifi
Copy link
Owner Author

mifi commented Dec 8, 2020

Ohh. Are you using "release: 4.3.1"? or "git master" ?

@mifi
Copy link
Owner Author

mifi commented Dec 8, 2020

Please try 4.3.1 and see if you get the same error

@cyrilgupta
Copy link

FFMPeg binaries on windows don't have the same version string. I am getting this - N-101088-g6f80953554

@mifi
Copy link
Owner Author

mifi commented Feb 15, 2021

where did you download ffmpeg from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants