Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on contribution preference. #42

Open
rbdr opened this issue Feb 2, 2025 · 0 comments
Open

Question on contribution preference. #42

rbdr opened this issue Feb 2, 2025 · 0 comments

Comments

@rbdr
Copy link

rbdr commented Feb 2, 2025

Howdy! Thanks for creating this, it's really cool! I'm exploring creating a Hotline community and found this project.

I have a question on your preference on how to handle contributions for new features.

For context: I've created a fork here: https://git.sr.ht/~rbdr/hotline, and I plan to add some features that I find helpful. I'd like to contribute these features back if you also think they're helpful for the main product.

For example, the one I'm currently working on:

  • Adds an autoconnect property to bookmarks, and ensures they're connected on startup even if the window is closed.
  • Adds a lightning bolt in the bookmark listing to toggle autoconnect.
  • Adds a reconnect timer to the server window that attempts a reconnect every 5 seconds if it gets logged out. (eg. if we lose network, or restart the server)
    https://git.sr.ht/~rbdr/hotline/commit/c676230cbc7da1c2c4d5540f89da32e9228deffd

To be more concrete:

  • Is this functionality you'd be interested in having in the main client?
  • If yes, do you have opinions on how this should be modeled?

For further functionality, if you're accepting contributions: Do you prefer PR first and discuss there, or discuss approach in issues first so the PR is more in line with what you have in mind for the architecture of the app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant