Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IE11 #79

Open
midzer opened this issue Jul 2, 2021 · 2 comments
Open

Drop IE11 #79

midzer opened this issue Jul 2, 2021 · 2 comments
Labels
question Further information is requested
Milestone

Comments

@midzer
Copy link
Owner

midzer commented Jul 2, 2021

I've found places in code where we can save some bytes by removing .keyCode. Current (optional) polyfill is for IE only, I think.

In Germany, less then 1% of users still use IE. So it's more or less dead after offical support has been dropped last year.

How about removing it for an upcoming v3?

@midzer midzer added the question Further information is requested label Jul 2, 2021
@viliusle
Copy link
Collaborator

viliusle commented Jul 3, 2021

I think it is not worth to work hard to support IE11, it means we can support only basic features, like open, next, previous, close. That's all.

I do not like dropping IE11 only to save few bytes.
If IE11 support would require extra development, then yes.

Overall, even dropping IE11, fallbacks will work on this browser, I mean click on image will still give you image (just not in modal window), same for iframe, youtube, inline.

@midzer midzer added this to the v3.0.0 milestone Jul 29, 2021
@viliusle
Copy link
Collaborator

viliusle commented Aug 5, 2021

It is already not working on IE.

@midzer midzer mentioned this issue Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants