Sorted transactions

midday-ai · Dec 3, 2024 · e51020f · e51020f
1 parent dadf3b5
commit e51020f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/apps/dashboard/jobs/tasks/bank/notifications/transactions.ts b/apps/dashboard/jobs/tasks/bank/notifications/transactions.ts
@@ -36,10 +36,14 @@ export const transactionNotifications = schemaTask({
         .eq("role", "owner")
         .throwOnError();
 
-      if (transactionsData && transactionsData.length > 0) {
-        await handleTransactionNotifications(usersData, transactionsData);
-        await handleTransactionEmails(usersData, transactionsData);
-        await handleTransactionSlackNotifications(teamId, transactionsData);
+      const sortedTransactions = transactionsData?.sort((a, b) => {
+        return new Date(b.date).getTime() - new Date(a.date).getTime();
+      });
+
+      if (sortedTransactions && sortedTransactions.length > 0) {
+        await handleTransactionNotifications(usersData, sortedTransactions);
+        await handleTransactionEmails(usersData, sortedTransactions);
+        await handleTransactionSlackNotifications(teamId, sortedTransactions);
       }
     } catch (error) {
       await logger.error("Transactions notification", { error });

diff --git a/apps/dashboard/jobs/tasks/bank/sync/connection.ts b/apps/dashboard/jobs/tasks/bank/sync/connection.ts
@@ -157,9 +157,6 @@ export const syncConnection = schemaTask({
           .from("bank_connections")
           .update({ status: "disconnected" })
           .eq("id", connectionId);
-
-        // Revalidate the bank cache (transactions, accounts, connections)
-        await revalidateCache({ tag: "bank", teamId: data.team_id });
       }
     } catch (error) {
       logger.error("Failed to sync connection", { error });

diff --git a/apps/dashboard/jobs/utils/transaction-notifications.ts b/apps/dashboard/jobs/utils/transaction-notifications.ts
@@ -51,8 +51,8 @@ export async function handleTransactionNotifications(
       name: TriggerEvents.TransactionsNewInApp,
       payload: {
         type: NotificationTypes.Transactions,
-        from: transactions[0]?.date,
-        to: transactions[transactions.length - 1]?.date,
+        from: transactions[transactions.length - 1]?.date,
+        to: transactions[0]?.date,
         description: t("notifications.transactions", {
           numberOfTransactions: transactions.length,
           // For single transaction

diff --git a/packages/email/emails/transactions.tsx b/packages/email/emails/transactions.tsx
@@ -291,7 +291,7 @@ export const TransactionsEmail = ({
             <Section className="text-center mt-[32px] mb-[32px]">
               <Button
                 className="bg-transparent text-primary text-[14px] text-[#121212] font-medium no-underline text-center px-6 py-3 border border-solid border-[#121212]"
-                href={`${baseAppUrl}/transactions?start=${transactions.at(0)?.date}&end=${transactions[transactions.length - 1]?.date}`}
+                href={`${baseAppUrl}/transactions?start=${transactions[transactions.length - 1]?.date}&end=${transactions.at(0)?.date}`}
               >
                 {t("transactions.button")}
               </Button>