From 92b9076a35b03364d521e4f2797fef0e91f41d20 Mon Sep 17 00:00:00 2001
From: AmirMS <104940545+AmelBawa-msft@users.noreply.github.com>
Date: Fri, 4 Oct 2024 14:30:39 -0700
Subject: [PATCH] remove pch

---
 .../UriValidation/UriValidation.vcxproj       | 16 ++------
 .../UriValidation.vcxproj.filters             |  6 ---
 src/Internal/UriValidation/pch.cpp            |  3 --
 src/Internal/UriValidation/pch.h              | 38 -------------------
 4 files changed, 4 insertions(+), 59 deletions(-)
 delete mode 100644 src/Internal/UriValidation/pch.cpp
 delete mode 100644 src/Internal/UriValidation/pch.h

diff --git a/src/Internal/UriValidation/UriValidation.vcxproj b/src/Internal/UriValidation/UriValidation.vcxproj
index 3cc26c6089..9b2099274e 100644
--- a/src/Internal/UriValidation/UriValidation.vcxproj
+++ b/src/Internal/UriValidation/UriValidation.vcxproj
@@ -58,8 +58,7 @@
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
-      <PrecompiledHeader>Use</PrecompiledHeader>
-      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
+      <PrecompiledHeader>NotUsing</PrecompiledHeader>
     </ClCompile>
     <Link>
       <SubSystem>
@@ -75,8 +74,7 @@
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
-      <PrecompiledHeader>Use</PrecompiledHeader>
-      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
+      <PrecompiledHeader>NotUsing</PrecompiledHeader>
     </ClCompile>
     <Link>
       <SubSystem>
@@ -92,8 +90,7 @@
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
-      <PrecompiledHeader>Use</PrecompiledHeader>
-      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
+      <PrecompiledHeader>NotUsing</PrecompiledHeader>
       <LanguageStandard>stdcpp17</LanguageStandard>
       <AdditionalIncludeDirectories>$(ProjectDir)..\..\AppInstallerSharedLib\Public;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
     </ClCompile>
@@ -111,8 +108,7 @@
       <SDLCheck>true</SDLCheck>
       <PreprocessorDefinitions>NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
-      <PrecompiledHeader>Use</PrecompiledHeader>
-      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
+      <PrecompiledHeader>NotUsing</PrecompiledHeader>
       <LanguageStandard>stdcpp17</LanguageStandard>
       <AdditionalIncludeDirectories>$(ProjectDir)..\..\AppInstallerSharedLib\Public;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
     </ClCompile>
@@ -125,13 +121,9 @@
     </Link>
   </ItemDefinitionGroup>
   <ItemGroup>
-    <ClInclude Include="pch.h" />
     <ClInclude Include="UriValidation.h" />
   </ItemGroup>
   <ItemGroup>
-    <ClCompile Include="pch.cpp">
-      <PrecompiledHeader>Create</PrecompiledHeader>
-    </ClCompile>
     <ClCompile Include="UriValidation_internal.cpp" Condition="Exists('$(MSBuildProjectDirectory)\UriValidation_internal.cpp')" />
     <ClCompile Include="UriValidation.cpp" Condition="!Exists('$(MSBuildProjectDirectory)\UriValidation_internal.cpp')" />
   </ItemGroup>
diff --git a/src/Internal/UriValidation/UriValidation.vcxproj.filters b/src/Internal/UriValidation/UriValidation.vcxproj.filters
index 3bd3d721e7..01ce4a95da 100644
--- a/src/Internal/UriValidation/UriValidation.vcxproj.filters
+++ b/src/Internal/UriValidation/UriValidation.vcxproj.filters
@@ -15,17 +15,11 @@
     </Filter>
   </ItemGroup>
   <ItemGroup>
-    <ClInclude Include="pch.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
     <ClInclude Include="UriValidation.h">
       <Filter>Header Files</Filter>
     </ClInclude>
   </ItemGroup>
   <ItemGroup>
-    <ClCompile Include="pch.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
     <ClCompile Include="UriValidation_internal.cpp" Condition="Exists('$(MSBuildProjectDirectory)\UriValidation_internal.cpp')">
       <Filter>Source Files</Filter>
     </ClCompile>
diff --git a/src/Internal/UriValidation/pch.cpp b/src/Internal/UriValidation/pch.cpp
deleted file mode 100644
index 147dc1b6e0..0000000000
--- a/src/Internal/UriValidation/pch.cpp
+++ /dev/null
@@ -1,3 +0,0 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
-#include "pch.h"
diff --git a/src/Internal/UriValidation/pch.h b/src/Internal/UriValidation/pch.h
deleted file mode 100644
index 107fc82d03..0000000000
--- a/src/Internal/UriValidation/pch.h
+++ /dev/null
@@ -1,38 +0,0 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
-#pragma once
-
-#define NOMINMAX
-#include <Windows.h>
-#include <AclAPI.h>
-#include <appmodel.h>
-#include <icu.h>
-#include <sddl.h>
-#include <Shlobj.h>
-#include <compressapi.h>
-#include <concurrencysal.h>
-
-#include <algorithm>
-#include <chrono>
-#include <cwctype>
-#include <filesystem>
-#include <fstream>
-#include <functional>
-#include <iomanip>
-#include <limits>
-#include <map>
-#include <memory>
-#include <mutex>
-#include <optional>
-#include <ostream>
-#include <set>
-#include <string>
-#include <sstream>
-#include <string_view>
-#include <type_traits>
-#include <vector>
-
-#include <winrt/Windows.ApplicationModel.Resources.h>
-#include <winrt/Windows.Foundation.h>
-#include <winrt/Windows.Globalization.h>
-#include <winrt/Windows.System.Profile.h>