Fix builds on WinUI and UWP .NET 9 projects #15004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Feb 7, 2025
There was a problem hiding this comment.
@nohwnd We could do a similar trick for WinUI so that if the user refs Microsoft.NET.Test.Sdk it's not causing a break of their app. WDYT?
|
Yes sure, this is fine. @Sergio0694 would you make a pr to vstest please? https://github.com/microsoft/vstest/blob/main/src/package/Microsoft.NET.Test.Sdk/netcoreapp/Microsoft.NET.Test.Sdk.targets#L24 |
Evangelink
approved these changes
Feb 7, 2025
Evangelink
approved these changes
Feb 7, 2025
Sergio0694
changed the title
|
I've updated the PR to also fix builds for WinUI! We should be good to go now. Thank you! 🙂 |
Youssef1313
approved these changes
Feb 7, 2025
|
@nohwnd Any concerns you have here or is it good to merge? |
Evangelink
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the .targets in the test SDK package to avoid breaking WinUI and UWP .NET 9 apps.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.