Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Color Picker: Keyboard accessibility #31637

Open
isidorn opened this issue Jul 28, 2017 · 9 comments
Open

[Feature] Color Picker: Keyboard accessibility #31637

isidorn opened this issue Jul 28, 2017 · 9 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2017

Refs: #31457

It is good that the color picker can be triggered via our "Show Hover" command, however after that you can not do any changes to it using the keyboard.
It should be possible to use the keyboard to navigate inside the color picker and choose colors appropriatly.

@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jul 28, 2017
@joaomoreno joaomoreno changed the title Color picker not accessible Color picker not keyboard accessible Aug 8, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug editor-color-picker Editor color picker widget issues labels Aug 8, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Aug 8, 2017
@joaomoreno joaomoreno changed the title Color picker not keyboard accessible Color Picker: Keyboard accessibility Aug 11, 2017
@joaomoreno joaomoreno assigned rebornix and unassigned joaomoreno Aug 14, 2017
@cleidigh
Copy link
Contributor

@isidorn
@joaomoreno
@rebornix

I would love to use the new color picker but I can't without keyboard support :-(
Would you accept a PR for this keyboard controller?

If so I'll make a proposal for the commands and approach...

@joaomoreno
Copy link
Member

@cleidigh Unfortunately you'll have to wait for @rebornix to return, he's currently on leave. But feel free to start crafting a PR which makes your life easier yeah! 👍

@rbenson
Copy link

rbenson commented May 14, 2018

Any updates to this?

@cleidigh
Copy link
Contributor

@rbenson
No update yet. Since accessibility is getting more more attention , I would assume this can get in the schedule sometime soon.

@isidorn
Copy link
Contributor Author

isidorn commented Nov 11, 2020

This should work when the Color Picker is triggered via Show Hover command the focus should be passed into the color hover. Once focus is there:

  • left, right, up, down should move the color
  • tab should allow to move focus to transparency

@rebornix might this be a good feature request for help-wanted tag? I am adding it and you can remove it.

@isidorn isidorn added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities and removed bug Issue identified by VS Code Team member as probable bug labels Nov 11, 2020
@ShahzaibParacha
Copy link

Since the help-wanted tag is on now, can I possibly take a look into this issue @isidorn?

@isidorn
Copy link
Contributor Author

isidorn commented Nov 12, 2020

@ShahzaibP I think yes. But it would be cool if @rebornix also gives his approval :)

@ShahzaibParacha
Copy link

Sure thing, I will wait for the approval!

@rebornix
Copy link
Member

rebornix commented Dec 8, 2020

You are being kind, you don't need my approval for a contribution, go ahead ❤️

@rebornix rebornix removed their assignment Oct 22, 2021
@aiday-mar aiday-mar self-assigned this Mar 3, 2023
@aiday-mar aiday-mar changed the title Color Picker: Keyboard accessibility [Feature] Color Picker: Keyboard accessibility Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

8 participants