Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Request the feature: "editor.lineHighlightForeground". #28299

Open
jsfag opened this issue Jun 9, 2017 · 5 comments
Open

[theme] Request the feature: "editor.lineHighlightForeground". #28299

jsfag opened this issue Jun 9, 2017 · 5 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality themes Color theme issues
Milestone
Backlog

Comments

@jsfag
Copy link

jsfag commented Jun 9, 2017 •
edited
Loading

Request the feature: "editor.lineHighlightForeground"

Sometimes it is essential to adjust the colour of the selected text by:
'editor.lineHighlightBackground'.

Colour merges if the highlighting line and text colours are identical.

An example:

'editor.lineHighlightBackground': '#000000', 'editor.lineHighlightForeground': '#fffffff'.

Cheers.
@bpasero bpasero removed their assignment Jun 9, 2017
@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues labels Jun 9, 2017
@aeschli
Copy link
Contributor

aeschli commented Jun 9, 2017

So all the text of the selected line would get the same foreground color? You would loose the syntax coloring...

@aeschli aeschli added this to the Backlog milestone Jun 9, 2017
@jsfag
Copy link
Author

jsfag commented Jun 9, 2017 •
edited
Loading

Thanks, this allows making high-contrast themes, simply: jsfag/Pushkin-is-White-Theme#1.

@jsfag
Copy link
Author

jsfag commented Aug 9, 2017

Hello! Any updates?

@aeschli
Copy link
Contributor

aeschli commented Aug 9, 2017

There are currently no plans on providing this feature, sorry.

@aeschli aeschli changed the title Request the feature: "editor.lineHighlightForeground". [theme] Request the feature: "editor.lineHighlightForeground". Nov 27, 2017
@jsfag
Copy link
Author

jsfag commented Feb 19, 2020

There are currently no plans on providing this feature, sorry.

Hello, any chance? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@bpasero @jsfag @aeschli