Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More font options #24830

Open
ajitid opened this issue Apr 15, 2017 · 2 comments
Open

More font options #24830

ajitid opened this issue Apr 15, 2017 · 2 comments
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality
Milestone

Comments

@ajitid
Copy link
Contributor

ajitid commented Apr 15, 2017

A lot of people use fonts like Fira Code, which doesn't has italics. Wouldn't that be great to have options to force no_italics, no_bold, etc?

@frankdugan3
Copy link

What I would like to see is the ability to choose separate fonts for different styles.

{
  "editor.fontFamily": "'Fira Code'",
  "editor.italicFontFamily": "'Ubuntu Mono'",
  ...
}

@alexdima alexdima added feature-request Request for new features or functionality editor-core Editor basic functionality editor labels Apr 26, 2017
@alexdima alexdima added this to the Backlog milestone Apr 26, 2017
@alexdima alexdima removed their assignment Apr 26, 2017
@ristomatti
Copy link
Contributor

ristomatti commented Dec 13, 2023

Odd, this used to work and I'm pretty sure it still worked not too long ago. This breaks my theme Solarized Dark Grey which uses bold to highlight keywords. I haven't used VSCode lately but it for sure worked when I've last updated the theme (6/7/2022).

Interestingly, if I adjust "editor.fontWeight", it only seems to have an effect if I set it to "800" (or higher) which makes the other parts of the code bold but not the keywords:

image

If set to a low value, e.g. "100" it doesn't have have the oppositive effect.

Edit: Nevermind, I had previously set the fontFamily to JetBrains Mono Medium. Changing to JetBrains Mono fixes the theme semantics but makes the fonts less legible. Anyhow, not related to this issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants
@alexdima @ristomatti @frankdugan3 @ajitid and others