Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions Recommendations : Can't undo "Don't Show Again for this Repository" #238800

Closed
kevinmarrec opened this issue Jan 26, 2025 · 6 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@kevinmarrec
Copy link

kevinmarrec commented Jan 26, 2025

Environment

  • VS Code Version: 1.96.4
  • OS Version: Windows 11

Does this issue occur when all extensions are disabled ?
Not applicable

Description

When a workspace provide a .vscode/extensions.json file to provide extensions recommendations, a notification is displayed and there's an option to never show it again for this workspace.

Image

Image

If clicked, it saves the action as a Workspace state entry which can't be undone from VSCode UI or configuration files.

Workspace states are usually found there: %vscodeInstallFolder%/User/workspaceStorage/%id/state.vscdb
These states have .vscdb extensions which seem to be backed by SQLite.

Image

The only way to undo it seems to either re-install VSCode or manually delete workspace states but I don't consider it as viable solution for the following reasons : not user friendly, not documented and therefore especially not error proof.

Here's the storage key that can't be unset forever :
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/extensions/browser/extensionRecommendationNotificationService.ts#L44

Image

Solution

Provides a VSCode command (F1) that would reset this action. (Ex: "Workspace: Reset extensions recommendations notifications")

Two possible implementations :

  • Toggling the boolean from true to false in the workspace state
  • Remove the key from workspace state
@gjsjohnmurray
Copy link
Contributor

See #24815

@kevinmarrec
Copy link
Author

Thank you for the link @gjsjohnmurray

Well, unfortunately the issue state is:

I don't know what we can do.

Based on my little dives into the VSCode codebase, I'm not sure it would be such a big deal to at least develop a part of the request (could be implementing it only for a single storage key first, then go generic).

@sandy081
Copy link
Member

/duplicate

#24815

@vs-code-engineering vs-code-engineering bot added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 27, 2025
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
@kevinmarrec
Copy link
Author

kevinmarrec commented Jan 27, 2025

@sandy081 Are we stuck with conversation locked 2017 issue ?

It seems @meganrogge implemented once a solution (#114114) but it has been closed, not merged.

If at least someone with collaborator access could give a state update to the main github issue #24815 as it's locked.

Thanks 🙏

@sandy081
Copy link
Member

Hi @kevinmarrec

Unfortunately #24815 is not in our near term Roadmap, hence it is not being attended. We will get back to this when it gets prioritised in our Roadmap. Unfortunately, I do not have any timeline. Sorry about that.

Thanks for understanding.

CC @bpasero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants