Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-comment: monaco editor should disable line-number manipulating API for extensions? #229521

Closed
ulugbekna opened this issue Sep 24, 2024 · 0 comments · Fixed by #230407
Closed

create-comment: monaco editor should disable line-number manipulating API for extensions? #229521

ulugbekna opened this issue Sep 24, 2024 · 0 comments · Fixed by #230407
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2024

Comments

@ulugbekna
Copy link
Contributor

ulugbekna commented Sep 24, 2024 •
edited
Loading

description

Editor used by create-comment view allows extensions to manipulate line number kind (relative vs absolute) making left padding none.

repro

  1. have vim extension
  2. set setting vim.smartRelativeLine to true (setting to configure line number (relative vs absolute) automatically depending on vim mode)
  3. checkout a PR and select lines and use gesture to write a comment on changes
  4. press i (a vim way of making editor non-readonly) - 🐛 line number appears too close to text
CleanShot.2024-09-24.at.11.18.14.mp4

same problem microsoft/vscode-python#24167

Version: 1.94.0-insider
Commit: f35c382
Date: 2024-09-24T05:04:12.797Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 24, 2024
@alexr00 alexr00 transferred this issue from microsoft/vscode-pull-request-github Sep 24, 2024
@alexr00 alexr00 added the comments Comments Provider/Widget/Panel issues label Sep 24, 2024
@alexr00 alexr00 added this to the October 2024 milestone Sep 24, 2024
alexr00 added a commit that referenced this issue Oct 3, 2024
@alexr00
create-comment: monaco editor should disable line-number manipulating…
5f06ff4 
… API for extensions?

Fixes #229521
@alexr00 alexr00 mentioned this issue Oct 3, 2024
Merged
@alexr00 alexr00 closed this as completed in 2e461da Oct 3, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 3, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 4, 2024
@connor4312 connor4312 added the verified Verification succeeded label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2024
3 participants
@connor4312 @ulugbekna @alexr00