Unable to write to dirty settings file

[isidorn]

Now we have more and more menu actions that write immediatly to settings, for instance toggle word wrap.
If you have a dirty settings.json all these actions are broken as I always get the erros that I am unable to write to a dirty settings file

I believe this can hurt a lot of our users as they usualy do not have auto save on, and showing an error message in this case looks bad imho.

[sandy081]

Related to #19625

[sandy081]

We can write into the opened buffer but saving the file automatically might be problematic. Because user might have changes which he does not want to save.

One approach is to inform user about saving the Settings for the action to take affect
Or to enable auto save for the settings always

[isidorn]

Enable auto save for settings, my suggestion :)

[sandy081]

Provided an option to save and retry settings in this case. This is a good compromise and helps users to quickly fix it.

[isidorn]

@sandy081 I get a nice error dialog to open settings, however I do not get the option to save and retry.
I am trying with user settings, latest insider

[sandy081]

@isidorn Please try when the file is dirty without any errors. If there are errors, then I show a message to open and fix errors.

[lynochka]

Hei, similary, would not allow to rewrite because of diry file {
"terminal.integrated.shell.windows": "C:\Windows\System32\cmd.exe"
}

please help