configuration.update doesn't do anything on malformed json

[WebFreak001]

Example user settings:

{
  "editor.renderWhitespace": "all",
}

It does get treated by vscode correctly (correctly parsed and used). However when calling

getConfiguration("test").update("foo", "bar", true);

now it won't do anything unless I remove that comma at the end of the line.

People who never edited the settings manually complained about my extension not correctly working because the config doesn't update.

[ramya-rao-a]

@sandy081 Would this be due to #16780?

[sandy081]

@ramya-rao-a Yes partially. This was fixed for internal usage but not in API. Will need to adopt and fix it.

[sandy081]

This got fixed with #19625