Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal panel layout wrong at certain sizes #183055

Open
Starwort opened this issue May 21, 2023 · 5 comments
Open

Terminal panel layout wrong at certain sizes #183055

Starwort opened this issue May 21, 2023 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues
Milestone

Comments

@Starwort
Copy link

Does this issue occur when all extensions are disabled?: Theoretically yes, but there aren't enough things in the bar by default

  • VS Code Version: 1.78.1, 1.79.0-insider
  • OS Version: Linux x64 5.19.0-40-generic

Steps to Reproduce:

  1. Resize the VSCode window to be roughly 1128px wide, with the left pane open to minimum width and the terminal open (to any height, including full dock)
  2. cd to any directory (mine was called frontend, but others should work)
  3. Observe that the terminal close button clips out of the side of the window

image

Extensions enabled: Gitlens (as it adds an item to the terminal pane) and Rust-analyzer (to generate two problems, to pad out the pane header)

Shell: Xonsh

@Tyriar
Copy link
Member

Tyriar commented May 21, 2023

@sbatten I can reproduce part of the clipping when there's a single tab

image

Could it be due to this part which is similar to the amount clipped?

image

Not sure if this would be on my end or yours?

@Starwort
Copy link
Author

Starwort commented May 23, 2023

Could it be due to this part which is similar to the amount clipped?

I don't believe so, as I was able to push the X all the way off the side with careful sizing

After a few more tests locally, it seems to be that when the name of the current directory is added to the terminal name, the terminal panel isn't reflowed - see below, with a much farther push due to 'Documents' being quite long

image

Edit: Strangely, I no longer seem to be able to resize the window small amounts to mess with the media query as before; but I believe the directory naming is the cause of the issue

@meganrogge
Copy link
Contributor

same as #122454

@Starwort
Copy link
Author

Yep, well spotted. Notably, though, it can be caused without intentionally renaming the terminal

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels May 25, 2023
@Tyriar Tyriar added this to the Backlog milestone May 25, 2023
@sbatten sbatten assigned benibenj and unassigned sbatten Sep 11, 2024
@benibenj benibenj reopened this Dec 16, 2024
@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2024

Unassigning terminal folks as it's a general view problem AFAICT.

@Tyriar Tyriar assigned sbatten and unassigned Tyriar and meganrogge Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

7 participants