Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Continue On cloning from codespace to local on desktop VS Code #172673

Closed
joyceerhl opened this issue Jan 27, 2023 · 5 comments · Fixed by #187301
Closed

Allow Continue On cloning from codespace to local on desktop VS Code #172673

joyceerhl opened this issue Jan 27, 2023 · 5 comments · Fixed by #187301
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug continue-working-on git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Collaborator

joyceerhl commented Jan 27, 2023

In virtual workspaces, the file dialog has a Show Local button. There's no such dialog in remote windows--the file dialog always shows the remote filesystem. This is an issue for continuing from a GitHub codespace to a local desktop clone when the user is in VS Code desktop.

Suggestion: when in a virtual or remote window on desktop, always have the 'Show Local' option in the file dialog.

@joyceerhl
Copy link
Collaborator Author

Oh interesting--there is a Show Local in the Open Folder flow, but not when the git extension invokes the file dialog:
image

@joyceerhl
Copy link
Collaborator Author

I see this was an intentional decision for extension access to the simple file dialog in a remote window in addaad3 for #110264

However that makes it hard to go from a remote window to a local one from extension land. Is this something that we can expose to extensions via a new proposed api option for the file dialog?

@joyceerhl joyceerhl changed the title No Show Local when launching file dialog in a remote window No Show Local when extension triggers file dialog in a remote window Jan 28, 2023
@alexr00
Copy link
Member

alexr00 commented Jan 30, 2023

Duplicate of #131138, which is an API request to expose "show local".

@alexr00 alexr00 closed this as completed Jan 30, 2023
@joyceerhl joyceerhl changed the title No Show Local when extension triggers file dialog in a remote window No Show Local when cloning from remote to local on desktop VS Code Feb 10, 2023
@joyceerhl
Copy link
Collaborator Author

Reopening this to track adoption of #131138 in the Continue On flow.

@joyceerhl joyceerhl reopened this Feb 10, 2023
@joyceerhl joyceerhl assigned joyceerhl and unassigned alexr00 Feb 10, 2023
@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Feb 10, 2023
@joyceerhl joyceerhl added this to the February 2023 milestone Feb 10, 2023
@joyceerhl joyceerhl modified the milestones: February 2023, Backlog Feb 22, 2023
@joyceerhl joyceerhl modified the milestones: Backlog, July 2023 Jul 7, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 7, 2023
@joyceerhl joyceerhl changed the title No Show Local when cloning from remote to local on desktop VS Code Allow Continue On cloning from codespace to local on desktop VS Code Jul 7, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 7, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 27, 2023
@joyceerhl
Copy link
Collaborator Author

Steps:

Open a codespace in VS Code desktop
From the remote indicator, choose Continue in Local Clone
Ensure that the repo gets cloned successfully to your local machine

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug continue-working-on git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
4 participants