Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Emmet: specified the attribute as [(ngModel)], but in the output, it came as [(ngModel}] with a closing brace instead of a parenthesis #171571

Open
adimittal opened this issue Jan 18, 2023 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@adimittal
Copy link

adimittal commented Jan 18, 2023

Does this issue occur when all extensions are disabled?: No, but I can't find Emmet in the Help > Report Issue > Extensions because Emmet, I believe is included with VSCode itself.

  • VS Code Version: Version: 1.74.3 (Universal)
  • OS Version: MacOS Big Sur

Steps to Reproduce:

  1. Create a snippets.json with the following on your computer:
    { "html": { "snippets": { "input": "div.input>label.form-label+input[[(ngModel)] type='text' name id title]/br" } } }
  2. Open the VS Code settings (Code → Preferences → Settings) and search for “Emmet Extensions Path”
  3. Click “Add Item,” enter the folder path where you’ve saved the snippets.json file, and press “OK”
  4. In VSCode editor, use Emmet to auto complete an input tag
  5. The output you get will be:
    `


    <input [(ngModel}]="" type="text" name="" id="" title="">

`

So, the bug is that we specified the attribute as [(ngModel)], but in the output, it came as [(ngModel}] with a closing brace instead of a parenthesis.

@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues confirmation-pending labels Jan 18, 2023
@rzhao271 rzhao271 added confirmed Issue has been confirmed by VS Code Team member and removed confirmation-pending labels Aug 2, 2023
@rzhao271
Copy link
Contributor

rzhao271 commented Aug 2, 2023

Related repro steps:

  1. In an HTML file, type div[(hello)] and try to expand it.
  2. 🐛 Nothing happens.

Even div[[[[hello]]]] works.

@rzhao271 rzhao271 added this to the Backlog milestone Aug 2, 2023
@rzhao271
Copy link
Contributor

rzhao271 commented Aug 3, 2023

Filed an upstream issue: emmetio/emmet#721

@rzhao271 rzhao271 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

2 participants