Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umask doesn't seem to be respected for the devcontainer process/instance #9041

Closed
3 tasks done
Tracked by #9044
dss010101 opened this issue Sep 28, 2023 · 4 comments
Closed
3 tasks done
Tracked by #9044
Assignees
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality

Comments

@dss010101
Copy link

Is there an existing issue for this bug?

  • I have searched the existing issues

Required Troubleshooting Steps

  • I have followed these troubleshooting steps
  • I have tried both values of the remote.SSH.useLocalServer setting

Connect Locally

It connects successfully

->

Im running an amazon al2023 image in a remote devcontainer. I have the following in the Dockerfile with hopes that files created within the container on mounted shares are read writeable by the dev team members.

    && echo "umask 0000" >> /home/$USER_NAME/.bashrc \
    && chown -R $USER_NAME /home/$USER_NAME
....
....
RUN mkdir -p $DATA_HOME
RUN chown -R $USER_NAME $DATA_HOME
RUN chmod -R g+rwx $DATA_HOME
RUN setfacl -Rdm g::rwx $DATA_HOME

$DATA_HOME above will be a mounted volume.

Within the VSCode's devcontainer, if i open a terminal and touch a file on the share, the permissions are fine - they are read writeable by the group. However, if i use visual studio code to create a file (File->New File), the file is r/w by only me. I was looking through the devcontainer build/start logs and noticed the following:

Start: Run in container: cat '/home/xxxxx/.vscode-server-insiders/data/Machine/.connection-token-8bac42dd1ec2bb223e847a16437b196c040680e5-insider' 2>/dev/null || (**umask 377** && echo 'd4e6cea0-208e-4030-ad16-cd4b3fcb4a42' >

Not sure if that is the mask that is used for the devcontainer process/instance...but if it is, how would i change that to 0002?
Or is there another solution for solving this issue?

It is quite a productivity problem when we constantly have to reach out to team members of admins to change file permissions

Thanks much

Expected Behavior

To be able to set umask at the devcontainer process level such that creation of files are group read/writeable on volumes shared by other members.

Steps To Reproduce

No response

Remote-SSH Log

Remote-SSH Log

[PASTE LOG HERE]

Anything else?

Opening here as per request frrom devcontainer github here: https://github.com/orgs/devcontainers/discussions/73

@dss010101 dss010101 added the ssh Issue in vscode-remote SSH label Sep 28, 2023
@protection6 protection6 mentioned this issue Sep 29, 2023
@paroj
Copy link

paroj commented Jan 10, 2024

the underlying issue is likely #9165

@joshspicer joshspicer added containers Issue in vscode-remote containers and removed ssh Issue in vscode-remote SSH labels Dec 12, 2024
@joshspicer joshspicer changed the title [Remote-SSH Bug]: umask doesn't seem to be respected for the devcontainer process/instance umask doesn't seem to be respected for the devcontainer process/instance Dec 12, 2024
@joshspicer joshspicer assigned chrmarti and unassigned roblourens Dec 12, 2024
@chrmarti chrmarti added the feature-request Request for new features or functionality label Dec 13, 2024
@vs-code-engineering vs-code-engineering bot added this to the Backlog Candidates milestone Dec 13, 2024
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 10 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

Copy link

This feature request has not yet received the 10 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

Copy link

🙁 In the last 60 days, this feature request has received less than 10 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants