Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode server updates don't follow update.mode #10612

Closed
AndrewNolte opened this issue Jan 6, 2025 · 5 comments
Closed

Vscode server updates don't follow update.mode #10612

AndrewNolte opened this issue Jan 6, 2025 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@AndrewNolte
Copy link

Related: #7211

I've tried with both "update.mode": "none" and "update.mode": "manual" in my user settings and it still automatically updates. I'll try to copy logs next time it happens.

@AndrewNolte AndrewNolte changed the title Vscode server updates don't respect update.mode Vscode server updates don't follow update.mode Jan 6, 2025
@joshspicer
Copy link
Member

joshspicer commented Jan 6, 2025

To confirm, this is for Remote - SSH?

The server on the remote host must match your local client version. If your local VS Code does not update, a previously downloaded version on the remote will be used (if present). Please do provide logs if you're seeing otherwise, and i'll be happy to dig in

@joshspicer joshspicer added the info-needed Issue requires more information from poster label Jan 6, 2025
@AndrewNolte
Copy link
Author

Yes, for ssh. Will update here, thanks!

@chrmarti chrmarti assigned joshspicer and unassigned chrmarti Jan 9, 2025
@AndrewNolte
Copy link
Author

Yeah I think it may be a client-side update issue, and then the remote just follows that version. I have

2025-02-12 10:01:46.767 [info] update#setState disabled
2025-02-12 10:01:46.769 [info] update#ctor - updates are disabled by user preference
2025-02-12 10:04:05.850 [info] Extension host with pid 67679 exited with code: 0, signal: unknown.

in my 'Main' logs, so glancing at the code it seems it's reading the settings properly- I have "update.mode": "none" set in my user settings.json.

applyUpdate() has other callsites though. Maybe there should be an extra setting that even these callsites can't get around, that is checked in applyUpdate()? I think there may be extensions forcing updates. I suspect copilot is forcing these updates, given how reliant it is on new vscode features- https://code.visualstudio.com/updates/v1_97

@joshspicer
Copy link
Member

The server version on the remote must match the client version exactly (same commit). If you want the server to not "update" you'll need to not update the client VS Code that you're connecting with. Does that make sense?

Due to this requirement a setting does not make sense here since it cannot be honored.

@AndrewNolte
Copy link
Author

Right, sorry for the noise- This was definitely an issue with the client-side version being updated, not with the remote side. We also don't think was from vscode attempting autoupdates

@AndrewNolte AndrewNolte closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants