Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint which repo an issue will be opened in #2099

Open
roblourens opened this issue Sep 1, 2020 · 5 comments · May be fixed by #6115
Open

Hint which repo an issue will be opened in #2099

roblourens opened this issue Sep 1, 2020 · 5 comments · May be fixed by #6115
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish

Comments

@roblourens
Copy link
Member

Testing #2095

I think it would be helpful if the new issue form editor would tell me which repo the issue is being opened in, just to give me confidence that it got it right.

@roblourens
Copy link
Member Author

Actually, why does "create PR" ask which repo to create it in, but "create issue" guesses based on context?

@alexr00 alexr00 self-assigned this Sep 3, 2020
@alexr00
Copy link
Member

alexr00 commented Sep 3, 2020

I'll add a decoration for it. We guess based on context because it seems likely that if you're creating an issue within VS Code you probably want to create an issue in the repo of the file you have open.

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug polish and removed bug Issue identified by VS Code Team member as probable bug labels Sep 3, 2020
@alexr00 alexr00 added this to the August 2020 milestone Sep 3, 2020
@alexr00
Copy link
Member

alexr00 commented Sep 3, 2020

Hmm, if you create a lot of issues back to back a decoration won't work because we don't know when a tab is closed to remove the decoration properly. You can get an old decoration which is extremely confusing. I'll have to add a new line to the document for the repo.

@alexr00 alexr00 modified the milestones: August 2020, September 2020 Sep 3, 2020
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 25, 2020
@alexr00 alexr00 modified the milestones: September 2020, October 2020 Sep 30, 2020
@alexr00 alexr00 modified the milestones: October 2020, November 2020 Oct 27, 2020
@alexr00 alexr00 modified the milestones: November 2020, December 2020 Nov 30, 2020
@alexr00 alexr00 modified the milestones: January 2021, February 2021 Jan 18, 2021
@RMacfarlane RMacfarlane modified the milestones: February 2021, March 2021 Feb 24, 2021
@alexr00 alexr00 removed this from the March 2021 milestone Feb 26, 2021
@mikeseese
Copy link

We guess based on context because it seems likely that if you're creating an issue within VS Code you probably want to create an issue in the repo of the file you have open.

This is definitely not the case in my workflow. Sometimes I discover a bug via using the terminal and proceed to make an issue. The open file can be one of many repos in my case. Perhaps an opt-in setting to disable guessing context and always prompt could solve our needs?

@mikeseese
Copy link

@alexr00 I know this issue is pretty stale, so I took a stab at both options in #6115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug polish
Projects
None yet
4 participants